Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Adding cancellation start time in client side TaskInfo #10384

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[Backport 2.x] Adding cancellation start time in client side TaskInfo #10384

merged 1 commit into from
Oct 5, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 71b6948 from #10326.

@github-actions
Adding cancellation start time in client side TaskInfo (#10326)
7243beb 
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
(cherry picked from commit 71b6948)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Compatibility status:

Checks if related components are compatible with change 7243beb

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git]

@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #10384 (7243beb) into 2.x (07ece0c) will decrease coverage by 0.15%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                2.x   #10384      +/-   ##
============================================
- Coverage     70.96%   70.81%   -0.15%     
+ Complexity    58415    58374      -41     
============================================
  Files          4818     4818              
  Lines        276019   276025       +6     
  Branches      40560    40561       +1     
============================================
- Hits         195875   195478     -397     
- Misses        63397    63865     +468     
+ Partials      16747    16682      -65
Files Coverage Δ
...ain/java/org/opensearch/client/tasks/TaskInfo.java 63.04% <50.00%> (+0.25%) ⬆️

... and 464 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Gradle Check (Jenkins) Run Completed with:

dblock
dblock approved these changes Oct 5, 2023
View reviewed changes
client/rest-high-level/src/main/java/org/opensearch/client/tasks/TaskInfo.java
@@ -250,6 +262,8 @@ public String toString() {
+ headers
+ ", resource_stats="
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm noticing this is not camelCase like others. Maybe @sgup432 you can followup on that? It's used in a log so maybe we can just change it?

@dblock
Copy link
Member

dblock commented Oct 5, 2023 •
edited
Loading

@sgup432 CHANGELOG is missing here, was it missing in the main merge too? realized this is an addition to a previous change

@dblock dblock merged commit 1926449 into 2.x Oct 5, 2023
38 of 64 checks passed
@github-actions github-actions bot deleted the backport/backport-10326-to-2.x branch October 5, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dblock