Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky testRemoteRefreshRetryOnFailure in RemoteStoreRefreshListenerIT #10464

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Oct 6, 2023

Description

This fixes #10459

Related Issues

Resolves #10459

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashking94 ashking94 changed the title Fix flaky testRemoteRefreshRetryOnFailure in RemoteStoreRefreshListen… Fix flaky testRemoteRefreshRetryOnFailure in RemoteStoreRefreshListenerIT Oct 6, 2023
@github-actions github-actions bot added bug Something isn't working Storage:Durability Issues and PRs related to the durability framework labels Oct 6, 2023
@ashking94 ashking94 marked this pull request as ready for review October 6, 2023 16:30
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Compatibility status:

Checks if related components are compatible with change 6198930

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@dblock
Copy link
Member

dblock commented Oct 6, 2023

Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar', will likely need some other PR with the version increment and/or a rebase.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

…erIT

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@ashking94
Copy link
Member Author

ashking94 commented Oct 7, 2023

Ran the tests for 100+ iterations and I dont see any failure which otherwise is failing around 30-40th iteration without the fix.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #10464 (6198930) into main (2bf63c9) will increase coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #10464      +/-   ##
============================================
+ Coverage     71.17%   71.27%   +0.09%     
- Complexity    58371    58436      +65     
============================================
  Files          4843     4843              
  Lines        275264   275264              
  Branches      40076    40076              
============================================
+ Hits         195928   196181     +253     
+ Misses        62882    62649     -233     
+ Partials      16454    16434      -20     

see 454 files with indirect coverage changes

@sachinpkale sachinpkale merged commit 732ce21 into opensearch-project:main Oct 7, 2023
16 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Oct 7, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 7, 2023
…erIT (#10464)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
(cherry picked from commit 732ce21)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ashking94 ashking94 deleted the 10459 branch October 7, 2023 08:44
gbbafna pushed a commit that referenced this pull request Oct 7, 2023
…erIT (#10464) (#10485)

(cherry picked from commit 732ce21)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 9, 2023
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…erIT (opensearch-project#10464)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working skip-changelog Storage:Durability Issues and PRs related to the durability framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure has become flaky
4 participants