Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download functionality of global metadata from remote store #10535

Conversation

dhwanilpatel
Copy link
Contributor

@dhwanilpatel dhwanilpatel commented Oct 10, 2023

Description

Changes for downloading global metadata to remote store.

It will download global metadata file and de-serialize it in Metadata object.

Related Issues

#10527

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Compatibility status:

Checks if related components are compatible with change 4f377d2

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

…_download

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #10535 (41ed4d3) into main (e942483) will increase coverage by 0.12%.
Report is 2 commits behind head on main.
The diff coverage is 86.66%.

❗ Current head 41ed4d3 differs from pull request most recent head 4f377d2. Consider uploading reports for the commit 4f377d2 to get more accurate results

@@             Coverage Diff              @@
##               main   #10535      +/-   ##
============================================
+ Coverage     71.12%   71.25%   +0.12%     
+ Complexity    58503    58452      -51     
============================================
  Files          4853     4844       -9     
  Lines        275915   275299     -616     
  Branches      40153    40084      -69     
============================================
- Hits         196256   196162      -94     
+ Misses        63247    62689     -558     
- Partials      16412    16448      +36     
Files Coverage Δ
...search/gateway/remote/ClusterMetadataManifest.java 97.65% <100.00%> (+1.85%) ⬆️
...arch/gateway/remote/RemoteClusterStateService.java 68.36% <84.61%> (+0.29%) ⬆️

... and 534 files with indirect coverage changes

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@dhwanilpatel dhwanilpatel changed the title Download funcationality of global metadata from remote store Download functionality of global metadata from remote store Oct 11, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

@amkhar amkhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT:
  • URL:
  • CommitID: 133c2ca
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

Copy link
Member

@shwetathareja shwetathareja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, lets rebase it once upload PR is merged.

…_download

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@shwetathareja shwetathareja merged commit 3a36c22 into opensearch-project:main Oct 18, 2023
13 of 14 checks passed
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 19, 2023
…ch-project#10535)

* Download funcationality of global metadata from remote store

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Oct 19, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 19, 2023
* Download funcationality of global metadata from remote store

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
(cherry picked from commit 3a36c22)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja pushed a commit that referenced this pull request Oct 19, 2023
…10733)

* Download funcationality of global metadata from remote store

(cherry picked from commit 3a36c22)

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
…ch-project#10535)

* Download funcationality of global metadata from remote store

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ch-project#10535)

* Download funcationality of global metadata from remote store

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants