Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.11] Fix flaky SearchScrollWithFailingNodesIT #10537

Closed
wants to merge 1 commit into from
Closed

[Backport 2.11] Fix flaky SearchScrollWithFailingNodesIT #10537

wants to merge 1 commit into from
+9 −9

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 562e3b2 from #10374.

@github-actions
Fix flaky SearchScrollWithFailingNodesIT (#10374)
b70f958 
The test intended to stop a data node and called a method named
`stopRandomNonClusterManagerNode()` in order to do that. However, that
method would stop a random node that was not the currently elected
cluster manager, regardless of node role. I have also renamed that
method hoping to be more clear.

Resolves #10137

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit 562e3b2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change b70f958

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #10537 (b70f958) into 2.11 (dc5128e) will increase coverage by 0.01%.
Report is 5 commits behind head on 2.11.
The diff coverage is 37.50%.

@@             Coverage Diff              @@
##               2.11   #10537      +/-   ##
============================================
+ Coverage     70.95%   70.96%   +0.01%     
+ Complexity    58565    58563       -2     
============================================
  Files          4829     4829              
  Lines        276379   276382       +3     
  Branches      40578    40578              
============================================
+ Hits         196099   196141      +42     
+ Misses        63593    63555      -38     
+ Partials      16687    16686       -1
Files Coverage Δ
...ibs/core/src/main/java/org/opensearch/Version.java 83.11% <100.00%> (+0.50%) ⬆️
...c/main/java/org/opensearch/index/IndexService.java 75.65% <ø> (ø)
.../org/opensearch/index/remote/RemoteStoreUtils.java 96.55% <ø> (-0.12%) ⬇️
...earch/index/store/RemoteSegmentStoreDirectory.java 88.88% <100.00%> (+0.03%) ⬆️
...ex/translog/transfer/TranslogTransferMetadata.java 85.00% <100.00%> (+0.38%) ⬆️
...a/org/opensearch/repositories/s3/S3Repository.java 58.27% <0.00%> (+0.41%) ⬆️
...in/java/org/opensearch/index/shard/IndexShard.java 68.67% <0.00%> (-1.06%) ⬇️

... and 456 files with indirect coverage changes

@opensearch-trigger-bot
Copy link
Contributor Author

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Nov 10, 2023
@ticheng-aws
Copy link
Contributor

ticheng-aws commented Jan 6, 2024 •
edited
Loading

Hi @andrross and @dblock, the PR is stalled. Could we close this?

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jan 7, 2024
@dblock
Copy link
Member

dblock commented Jan 9, 2024

Let's close this, thanks.

@dblock dblock closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89 dreamer-89 is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ticheng-aws @dblock