Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make search pipelines asynchronous #10598

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Make search pipelines asynchronous #10598

merged 3 commits into from
Oct 30, 2023
+291 −124

Commits on Oct 27, 2023

  1. Make search pipelines asynchronous 

    If a search processor needs to make a call out to another
service, we should not risk blocking on the transport thread. We should
support async execution.

Signed-off-by: Michael Froh <froh@amazon.com>
    @msfroh
    msfroh committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    7f5889a View commit details
    Browse the repository at this point in the history

  2. Compute pipelineStart before building request callback chain 

    Also, IntelliJ suggested refactoring creation of the terminal request
callback into a separate method since the existing method was really
big. I liked that suggestion.

Signed-off-by: Michael Froh <froh@amazon.com>
    @msfroh
    msfroh committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    6f823bd View commit details
    Browse the repository at this point in the history

  3. Rename async methods (put async at end) 

    Signed-off-by: Michael Froh <froh@amazon.com>
    @msfroh
    msfroh committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    70567bd View commit details
    Browse the repository at this point in the history