Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Enhancing FS stats to include read / write time, io time and queue size #10696

Merged
merged 2 commits into from
Oct 18, 2023
Merged

[Backport 2.x] Enhancing FS stats to include read / write time, io time and queue size #10696

merged 2 commits into from
Oct 18, 2023

Conversation

bharath-techie
Copy link
Contributor

Description

Backport of FS stats PR - #10541

Related Issues

#8910

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bharath-techie
Enhancing FS stats to include read/write time, queue size and IO time (…
2ee450d 
…opensearch-project#10541)

* Enhancing FS stats to include read / write time, io time and queue size

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 1a3e938

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@bharath-techie bharath-techie changed the title Enhancing FS stats to include read / write time, io time and queue size [Backport 2.x] Enhancing FS stats to include read / write time, io time and queue size Oct 18, 2023
@bharath-techie
2.x specific changes
1a3e938 
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #10696 (1a3e938) into 2.x (e611185) will increase coverage by 0.06%.
Report is 6 commits behind head on 2.x.
The diff coverage is 68.75%.

@@             Coverage Diff              @@
##                2.x   #10696      +/-   ##
============================================
+ Coverage     70.93%   70.99%   +0.06%     
- Complexity    58575    58586      +11     
============================================
  Files          4830     4830              
  Lines        276453   276548      +95     
  Branches      40588    40606      +18     
============================================
+ Hits         196091   196336     +245     
+ Misses        63676    63506     -170     
- Partials      16686    16706      +20
Files Coverage Δ
...ch/repositories/gcs/GoogleCloudStorageService.java 82.43% <100.00%> (ø)
...c/main/java/org/opensearch/monitor/fs/FsProbe.java 82.35% <50.00%> (-2.03%) ⬇️
.../org/opensearch/repositories/gcs/SocketAccess.java 68.42% <33.33%> (-14.92%) ⬇️
...rc/main/java/org/opensearch/monitor/fs/FsInfo.java 71.85% <71.76%> (+2.65%) ⬆️

... and 454 files with indirect coverage changes

@bharath-techie
Copy link
Contributor Author

Codecov reduction is due to serialization / deserialization lines which are covered in IT and BWC tests

@gbbafna gbbafna merged commit f00103c into opensearch-project:2.x Oct 18, 2023
15 of 16 checks passed
@bharath-techie bharath-techie mentioned this pull request Oct 19, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta left review comments

@gbbafna gbbafna gbbafna approved these changes

@kkmr kkmr kkmr approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bharath-techie @reta @kkmr @gbbafna