-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return unformatted Segment Replication metrics that take upload time into account for replication lag #10723
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change c042c17 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git] |
server/src/main/java/org/opensearch/index/ReplicationStats.java
Outdated
Show resolved
Hide resolved
4ab7fcb
to
3004cca
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/index/ReplicationStats.java
Outdated
Show resolved
Hide resolved
b7aa214
to
f171a97
Compare
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
f171a97
to
03a7755
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10723 +/- ##
============================================
+ Coverage 71.12% 71.23% +0.11%
- Complexity 58545 58606 +61
============================================
Files 4859 4859
Lines 276252 276269 +17
Branches 40191 40193 +2
============================================
+ Hits 196473 196800 +327
+ Misses 63347 63035 -312
- Partials 16432 16434 +2
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit comment, but given this is a field name which is user facing, pls incorporate the same.
server/src/main/java/org/opensearch/index/ReplicationStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/ReplicationStats.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
…into account for replication lag (#10723) * Return unformatted segrep metrics in stats Signed-off-by: Poojita Raj <poojiraj@amazon.com> * Take upload time into account for replication time lag Signed-off-by: Poojita Raj <poojiraj@amazon.com> * unformat segrep stats Signed-off-by: Poojita Raj <poojiraj@amazon.com> * remove unused field names Signed-off-by: Poojita Raj <poojiraj@amazon.com> --------- Signed-off-by: Poojita Raj <poojiraj@amazon.com> (cherry picked from commit 4f8bcff) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…into account for replication lag (#10723) (#10804) * Return unformatted segrep metrics in stats * Take upload time into account for replication time lag * unformat segrep stats * remove unused field names --------- (cherry picked from commit 4f8bcff) Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…into account for replication lag (opensearch-project#10723) * Return unformatted segrep metrics in stats Signed-off-by: Poojita Raj <poojiraj@amazon.com> * Take upload time into account for replication time lag Signed-off-by: Poojita Raj <poojiraj@amazon.com> * unformat segrep stats Signed-off-by: Poojita Raj <poojiraj@amazon.com> * remove unused field names Signed-off-by: Poojita Raj <poojiraj@amazon.com> --------- Signed-off-by: Poojita Raj <poojiraj@amazon.com>
…into account for replication lag (opensearch-project#10723) * Return unformatted segrep metrics in stats Signed-off-by: Poojita Raj <poojiraj@amazon.com> * Take upload time into account for replication time lag Signed-off-by: Poojita Raj <poojiraj@amazon.com> * unformat segrep stats Signed-off-by: Poojita Raj <poojiraj@amazon.com> * remove unused field names Signed-off-by: Poojita Raj <poojiraj@amazon.com> --------- Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This change does 2 things:
MAX_REPLICATION_LAG
now takes into account the total replication lag i.e., it now includes the time taken to upload data to the remote store.Related Issues
Resolves #10666
Resolves #10722
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.