Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA to verify checklist items completion in PR descriptions #10800

Merged
merged 9 commits into from
Oct 24, 2023
Merged

GHA to verify checklist items completion in PR descriptions #10800

merged 9 commits into from
Oct 24, 2023

Conversation

peternied
Copy link
Member

@peternied peternied commented Oct 20, 2023 •
edited
Loading

Description

GHA to verify checklist items completion in PR descriptions

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied
Add workflow for pull request specific checks
b247947 
Job that verifies the description checklist items are completed or
invalid

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied
Fix incorrect parameter
c376211 
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied
Don't limit pull request trigger types
bd9a6da 
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied
Add that missing 'i'
2aed037 
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied
Small whitespace change
0219b46 
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied
Update triggers for the pull request checks
c212a8b 
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied
Format document
ce61acb 
Signed-off-by: Peter Nied <petern@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 158d0bd

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@peternied peternied changed the title Add workflow for pull request specific checks GHA to verify checklist items completion in PR descriptions Oct 20, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Merging #10800 (158d0bd) into main (da85124) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #10800      +/-   ##
============================================
- Coverage     71.31%   71.16%   -0.15%     
+ Complexity    58711    58665      -46     
============================================
  Files          4869     4869              
  Lines        276489   276489              
  Branches      40202    40202              
============================================
- Hits         197183   196773     -410     
- Misses        62873    63300     +427     
+ Partials      16433    16416      -17

see 448 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@peternied
Merge remote-tracking branch 'origin/main' into pull-request-checks
21a9a26 
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied
Ready for merging
158d0bd 
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied marked this pull request as ready for review October 23, 2023 21:29
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled

This was referenced Oct 24, 2023
Closed
Closed
Closed
@peternied peternied merged commit 5bd413c into opensearch-project:main Oct 24, 2023
74 of 101 checks passed
@peternied peternied deleted the pull-request-checks branch October 24, 2023 11:38
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@peternied @shiv0408
GHA to verify checklist items completion in PR descriptions (opensear…
acfc6f5 
…ch-project#10800)

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peternied @reta