Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to nodes/stats #10887

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to nodes/stats #10887

merged 6 commits into from
Nov 29, 2023

Conversation

ajaymovva
Copy link
Contributor

@ajaymovva ajaymovva commented Oct 24, 2023 •
edited
Loading

Description

Added changes to integrate cpu AC to ResourceUsageCollector and Emit Stats

Related Issues

Ref: #8910

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ajaymovva ajaymovva changed the title Feature/admission control Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats Oct 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change bcbd91e

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ajaymovva ajaymovva mentioned this pull request Oct 26, 2023
Open
14 tasks
@ajaymovva ajaymovva force-pushed the feature/admission-control branch from fbbf4e8 to 4801a0c Compare October 26, 2023 07:40
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 777cd03: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ajaymovva ajaymovva force-pushed the feature/admission-control branch from 777cd03 to 07b4141 Compare November 12, 2023 09:08
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 07b4141: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testDefaultBufferInterval

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@ajaymovva ajaymovva force-pushed the feature/admission-control branch from 07b4141 to a81b6d0 Compare November 17, 2023 07:24
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for a81b6d0: SUCCESS

Bukhtawar
Bukhtawar approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ajay Kumar Movva and others added 6 commits November 29, 2023 12:30
Added changes to integrade cpu AC to ResourceUsageCollector and Emit …
9e7f697 
…Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
@bharath-techie
javadoc changes and more
353e950 
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
@bharath-techie
Fixes for tests
f1ea3cb 
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Added Multi Node Integration Tests
6a3f806 
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Addressing Comments
97e9b03 
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Addressing Comments
bcbd91e 
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
@ajaymovva ajaymovva force-pushed the feature/admission-control branch from a81b6d0 to bcbd91e Compare November 29, 2023 07:04
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for bcbd91e: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.reindex.UpdateByQueryBasicTests.testMultipleSources

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@Bukhtawar Bukhtawar merged commit 0b49929 into opensearch-project:main Nov 29, 2023
29 checks passed
fahadshamiinsta pushed a commit to fahadshamiinsta/OpenSearch270 that referenced this pull request Dec 4, 2023
@ajaymovva @bharath-techie @fahadshamiinsta
Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to …
e842761 
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Bharathwaj G <bharath78910@gmail.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Dec 11, 2023
@ajaymovva @bharath-techie @deshsidd
Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to …
441e5c1 
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Bharathwaj G <bharath78910@gmail.com>
@ajaymovva ajaymovva mentioned this pull request Jan 24, 2024
Merged
1 task
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Jan 29, 2024
@ajaymovva @bharath-techie
Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to …
2625732 
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Bharathwaj G <bharath78910@gmail.com>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Jan 31, 2024
@ajaymovva @bharath-techie
Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to …
bec0e81 
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Bharathwaj G <bharath78910@gmail.com>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Jan 31, 2024
@ajaymovva @bharath-techie
Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to …
eca542b 
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Bharathwaj G <bharath78910@gmail.com>
@ajaymovva ajaymovva mentioned this pull request Feb 1, 2024
Merged
8 tasks
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Feb 4, 2024
@ajaymovva @bharath-techie
Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to …
fb0143d 
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Bharathwaj G <bharath78910@gmail.com>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Feb 5, 2024
@ajaymovva @bharath-techie
Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to …
8932ef2 
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Bharathwaj G <bharath78910@gmail.com>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Feb 6, 2024
@ajaymovva @bharath-techie
Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to …
bca095e 
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Bharathwaj G <bharath78910@gmail.com>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Feb 6, 2024
@ajaymovva @bharath-techie
Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to …
1467c4d 
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Bharathwaj G <bharath78910@gmail.com>
sachinpkale pushed a commit that referenced this pull request Feb 6, 2024
@ajaymovva @bharath-techie
[Backport 2.x] AdmissionControl Framework with CPU Based Admission Co…
f67ed17 
…ntroller (#12111)

* Added changes for AdmissionControl Interceptor and AdmissionControlService for RateLimiting (#9286)

* Changes for AdmissionControl Interceptor and AdmissionControlService for RateLimiting (#9286)

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to nodes/stats (#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Bharathwaj G <bharath78910@gmail.com>

* Updating Version to 2.12 for the AC Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

---------

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Bharathwaj G <bharath78910@gmail.com>
Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
@ajaymovva ajaymovva deleted the feature/admission-control branch February 9, 2024 12:05
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@ajaymovva @bharath-techie @rayshrey
Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to …
d55d08f 
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Bharathwaj G <bharath78910@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@ajaymovva @bharath-techie @shiv0408
Integrate CPU AC with ResourceUsageCollector and add CPU AC stats to …
0bd5ba1 
…nodes/stats (opensearch-project#10887)

* Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharath-techie bharath-techie bharath-techie approved these changes

@BhumikaSaini-Amazon BhumikaSaini-Amazon BhumikaSaini-Amazon approved these changes

@gashutos gashutos gashutos approved these changes

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@adnapibar adnapibar Awaiting requested review from adnapibar

@tlfeng tlfeng Awaiting requested review from tlfeng

Assignees

@ajaymovva ajaymovva

Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ajaymovva @BhumikaSaini-Amazon @Bukhtawar @bharath-techie @gashutos @rramachand21