Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test IndexShardTests.testLocalDirectoryContains #10929

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix flaky test IndexShardTests.testLocalDirectoryContains #10929

merged 1 commit into from
Oct 25, 2023

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Oct 25, 2023 •
edited
Loading

Description

This test is breaking for WindowsFS only. Moving it to a separate file where it is skipped on WindowsFS.

Related Issues

Resolves #10927

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mch2
Fix flaky test IndexShardTests.testLocalDirectoryContains
6379f73 
This test is breaking for WindowsFS only. Moving it to a separate file where it is skipped on WindowsFS.

Signed-off-by: Marc Handalian <handalm@amazon.com>
@github-actions github-actions bot added the bug Something isn't working label Oct 25, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 6379f73

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #10929 (6379f73) into main (5a288ed) will decrease coverage by 0.10%.
Report is 10 commits behind head on main.
The diff coverage is 55.04%.

@@             Coverage Diff              @@
##               main   #10929      +/-   ##
============================================
- Coverage     71.22%   71.13%   -0.10%     
- Complexity    58678    58740      +62     
============================================
  Files          4869     4872       +3     
  Lines        276496   276682     +186     
  Branches      40203    40219      +16     
============================================
- Hits         196936   196811     -125     
- Misses        63114    63502     +388     
+ Partials      16446    16369      -77
Files Coverage Δ
...search/repositories/s3/AmazonAsyncS3Reference.java 84.61% <100.00%> (+1.28%) ⬆️
.../repositories/s3/AmazonAsyncS3WithCredentials.java 100.00% <100.00%> (ø)
...org/opensearch/repositories/s3/S3AsyncService.java 72.28% <100.00%> (+1.09%) ⬆️
...va/org/opensearch/repositories/s3/S3BlobStore.java 68.75% <100.00%> (+0.49%) ⬆️
...a/org/opensearch/repositories/s3/S3Repository.java 70.08% <100.00%> (+0.25%) ⬆️
...search/cluster/coordination/CoordinationState.java 88.39% <ø> (ø)
.../org/opensearch/cluster/service/MasterService.java 84.51% <100.00%> (-0.56%) ⬇️
...h/common/blobstore/stream/write/WritePriority.java 100.00% <100.00%> (ø)
...nsearch/gateway/remote/RemotePersistenceStats.java 100.00% <100.00%> (ø)
...epositories/blobstore/ChecksumBlobStoreFormat.java 95.45% <100.00%> (+0.29%) ⬆️
... and 12 more

... and 466 files with indirect coverage changes

@mch2
Copy link
Member Author

mch2 commented Oct 25, 2023

Gradle Check (Jenkins) Run Completed with:

#9605

dreamer-89
dreamer-89 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mch2 for quickly fixing this.

@mch2 mch2 added the backport 2.x Backport to 2.x branch label Oct 25, 2023
@mch2 mch2 merged commit fb6fe1b into opensearch-project:main Oct 25, 2023
50 of 104 checks passed
@mch2 mch2 deleted the ldc branch October 25, 2023 21:20
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 25, 2023
@github-actions
Fix flaky test IndexShardTests.testLocalDirectoryContains (#10929)
cec0b5f 
This test is breaking for WindowsFS only. Moving it to a separate file where it is skipped on WindowsFS.

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit fb6fe1b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 25, 2023
Merged
mch2 pushed a commit that referenced this pull request Oct 26, 2023
@opensearch-trigger-bot @github-actions
Fix flaky test IndexShardTests.testLocalDirectoryContains (#10929) (#…
3dcbe1d 
…10932)

This test is breaking for WindowsFS only. Moving it to a separate file where it is skipped on WindowsFS.


(cherry picked from commit fb6fe1b)

Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@mch2 @shiv0408
Fix flaky test IndexShardTests.testLocalDirectoryContains (opensearch…
3a3c0eb 
…-project#10929)

This test is breaking for WindowsFS only. Moving it to a separate file where it is skipped on WindowsFS.

Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamer-89 dreamer-89 dreamer-89 approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch bug Something isn't working skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.index.shard.IndexShardTests.testLocalDirectoryContains is flaky
2 participants
@mch2 @dreamer-89