Per request latency onPhaseEnd fix

[dzane17]

Description

We need to call onPhaseEnd() before buildSearchResponse() else the SearchResponse will not have phase took time for the last phase.

Original PR: #10351

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change f4475b7

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards

• URL: https://build.ci.opensearch.org/job/gradle-check/29038/
• CommitID: f26b573
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ff7e97) 71.15% compared to head (f4475b7) 71.14%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10934      +/-   ##
============================================
- Coverage     71.15%   71.14%   -0.02%     
- Complexity    58783    58796      +13     
============================================
  Files          4885     4885              
  Lines        277199   277199              
  Branches      40285    40285              
============================================
- Hits         197247   197212      -35     
- Misses        63448    63559     +111     
+ Partials      16504    16428      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dzane17]

@msfroh thoughts? Also please add 2.x label.

[msfroh]

@msfroh thoughts? Also please add 2.x label.

Sorry -- I missed the notification on this one. Looks good 👍

@dzane17 Can you please add a changelog entry?

[github-actions]

❕ Gradle check result for f4475b7: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testTrackerData

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[dzane17]

@msfroh I updated changelog

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10934-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 379acf30cce5fe3b38bbd806183bf06f6937450a
# Push it to GitHub
git push --set-upstream origin backport/backport-10934-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-10934-to-2.x.