Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mute testSegRepSucceedsOnPreviousCopiedFiles and testNoFailuresOnFileReads unit tests #10942

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Mute testSegRepSucceedsOnPreviousCopiedFiles and testNoFailuresOnFileReads unit tests #10942

merged 1 commit into from
Oct 26, 2023

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Oct 26, 2023 •
edited
Loading

Description

testSegRepSucceedsOnPreviousCopiedFiles and testNoFailuresOnFileReads have been found to be flaky in recent gradle check runs, resulting in failures. As part of this PR, muting these two tests until it is fixed. Both tests have similar code flow structure, hence using same tracking issue.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
Related #10885

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89
Mute testSegRepSucceedsOnPreviousCopiedFiles and testNoFailuresOnFile…
cd33f0a 
…Reads unit tests

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@dreamer-89 dreamer-89 added skip-changelog backport 2.x Backport to 2.x branch labels Oct 26, 2023
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change cd33f0a

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #10942 (cd33f0a) into main (fe8b2d5) will increase coverage by 0.21%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #10942      +/-   ##
============================================
+ Coverage     71.11%   71.33%   +0.21%     
- Complexity    58687    58767      +80     
============================================
  Files          4872     4872              
  Lines        276691   276691              
  Branches      40221    40221              
============================================
+ Hits         196770   197377     +607     
+ Misses        63523    62854     -669     
- Partials      16398    16460      +62

see 454 files with indirect coverage changes

@dreamer-89 dreamer-89 merged commit 5ae9333 into opensearch-project:main Oct 26, 2023
60 of 119 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 26, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 26, 2023
@github-actions
Mute testSegRepSucceedsOnPreviousCopiedFiles and testNoFailuresOnFile…
89caa7f 
…Reads unit tests (#10942)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit 5ae9333)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89 pushed a commit that referenced this pull request Oct 26, 2023
@opensearch-trigger-bot @github-actions
Mute testSegRepSucceedsOnPreviousCopiedFiles and testNoFailuresOnFile…
24fa926 
…Reads unit tests (#10942) (#10947)

(cherry picked from commit 5ae9333)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@dreamer-89 @shiv0408
Mute testSegRepSucceedsOnPreviousCopiedFiles and testNoFailuresOnFile…
fa3d999 
…Reads unit tests (opensearch-project#10942)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mch2 mch2 mch2 approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreamer-89 @mch2