Ensure that segments are upload to remote store in case of local and …

[gbbafna]

…snapshot based recovery

Description

Ensure that segments are upload to remote store in case of local and snapshot recovery before activating the primary mode.

Related Issues

Resolves #10957

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
  - [x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  - [x] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29088/
• CommitID: ad73e1a
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Compatibility status:

Checks if related components are compatible with change b987c55

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29087/
• CommitID: 4877b9b
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      2 org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads

• URL: https://build.ci.opensearch.org/job/gradle-check/29089/
• CommitID: 0fac132
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #10948 (0fac132) into main (fe8b2d5) will increase coverage by 0.08%.
Report is 6 commits behind head on main.
The diff coverage is 4.00%.

❗ Current head 0fac132 differs from pull request most recent head b987c55. Consider uploading reports for the commit b987c55 to get more accurate results

@@             Coverage Diff              @@
##               main   #10948      +/-   ##
============================================
+ Coverage     71.11%   71.20%   +0.08%     
- Complexity    58687    58709      +22     
============================================
  Files          4872     4872              
  Lines        276691   276715      +24     
  Branches      40221    40231      +10     
============================================
+ Hits         196770   197029     +259     
+ Misses        63523    63241     -282     
- Partials      16398    16445      +47     

Files	Coverage Δ
...search/index/shard/RemoteStoreRefreshListener.java	85.09% <20.00%> (-1.67%)	⬇️
...in/java/org/opensearch/index/shard/IndexShard.java	69.77% <0.00%> (+0.48%)	⬆️
...java/org/opensearch/index/shard/StoreRecovery.java	55.21% <0.00%> (-2.01%)	⬇️

... and 451 files with indirect coverage changes

[ashking94]

LGTM!!

[ashking94]

Lets add tests as well. Ty!

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29133/
• CommitID: 343a385
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29134/
• CommitID: 00e4ad4
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29142/
• CommitID: b422212
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29163/
• CommitID: b987c55
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[sachinpkale]

Flaky tests are failing.