Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated classes for Rounding #10956

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Remove deprecated classes for Rounding #10956

merged 1 commit into from
Oct 27, 2023

Conversation

ketanv3
Copy link
Contributor

@ketanv3 ketanv3 commented Oct 27, 2023 •
edited
Loading

Description

Joda based Rounding class was deprecated in 87481a0 and Java based Rounding class was introduced. The deprecated classes aren't used anywhere outside some tests and benchmarks, so this PR removes it completely.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ketanv3
Remove deprecated classes for Rounding
e67efeb 
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change e67efeb

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #10956 (e67efeb) into main (0c9fc21) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #10956      +/-   ##
============================================
- Coverage     71.23%   71.12%   -0.12%     
+ Complexity    58730    58661      -69     
============================================
  Files          4872     4870       -2     
  Lines        276707   276539     -168     
  Branches      40222    40190      -32     
============================================
- Hits         197124   196685     -439     
- Misses        63115    63442     +327     
+ Partials      16468    16412      -56

see 490 files with indirect coverage changes

@ketanv3 ketanv3 marked this pull request as ready for review October 27, 2023 07:59
@reta reta merged commit be65f54 into opensearch-project:main Oct 27, 2023
105 of 107 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Oct 27, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 27, 2023
@github-actions
Remove deprecated classes for Rounding (#10956)
e198a63 
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
(cherry picked from commit be65f54)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 27, 2023
Merged
reta pushed a commit that referenced this pull request Oct 27, 2023
@opensearch-trigger-bot @github-actions
Remove deprecated classes for Rounding (#10956) (#10963)
50642fa 
(cherry picked from commit be65f54)

Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@BrewTestBot BrewTestBot mentioned this pull request Feb 21, 2024
Merged
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@ketanv3 @shiv0408
Remove deprecated classes for Rounding (opensearch-project#10956)
b688e29 
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ketanv3 @reta