-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding slf4j license header to LoggerMessageFormat.java #11069
Conversation
Signed-off-by: Henri Yandell <hyandell@amazon.com>
Compatibility status:Checks if related components are compatible with change 757409a Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer-rca.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #11069 +/- ##
============================================
- Coverage 71.29% 71.20% -0.09%
- Complexity 58742 58787 +45
============================================
Files 4872 4872
Lines 276777 276780 +3
Branches 40240 40241 +1
============================================
- Hits 197316 197070 -246
- Misses 62943 63327 +384
+ Partials 16518 16383 -135
|
Thanks for digging into this @hyandell - changes look good to me, I'll see about getting this merged. |
Signed-off-by: Peter Nied <petern@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11069-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c851b34735294a4eb6baf5c1254de1b130daa6c4
# Push it to GitHub
git push --set-upstream origin backport/backport-11069-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
I presume we need to backport it to active branches, I would do 2.x and 1.x. |
Definitely looking for y'all to manage your backports :) But +1 to applying this on the active branches. |
@hyandell You'll have to manually backport to 2.x and 1.x, these are active trees. |
…roject#11069) * Adding slf4j license header per opensearch-project#9879 Signed-off-by: Henri Yandell <hyandell@amazon.com> Signed-off-by: Henri Yandell <477715+hyandell@users.noreply.github.com> Signed-off-by: Peter Nied <petern@amazon.com> Co-authored-by: Peter Nied <petern@amazon.com>
…roject#11069) * Adding slf4j license header per opensearch-project#9879 Signed-off-by: Henri Yandell <hyandell@amazon.com> Signed-off-by: Henri Yandell <477715+hyandell@users.noreply.github.com> Signed-off-by: Peter Nied <petern@amazon.com> Co-authored-by: Peter Nied <petern@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Per #9879, I've added my suggested source header. I've only eyeballed the code (it's a comment being added) and haven't run any compiling/testing. No concerns if folk want to do a different PR for this, but I'm only a brief visitor to these shores.
Related Issues
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedPublic documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.