Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] [Streaming Indexing] Introduce new experimental HTTP transport based on Netty 4 and Project Reactor (Reactor Netty) (#9672) #11108

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Nov 6, 2023

Backport of #9672 to 2.x

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Compatibility status:

Checks if related components are compatible with change c737c9d

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@reta reta force-pushed the backport/backport-9672-to-2.x branch from b8d2ed5 to 16007d1 Compare November 6, 2023 18:19
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@reta reta force-pushed the backport/backport-9672-to-2.x branch from 16007d1 to a768e0e Compare November 6, 2023 18:57
…on Netty 4 and Project Reactor (Reactor Netty) (opensearch-project#9672)

* [Streaming Indexing] Introduce new experimental server HTTP transport based on Netty 4 and Project Reactor (Reactor Netty)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Remove HttpChunk for now since it is not used in non-streaming APIs

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Fix postmerge issues

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 1782b90)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta force-pushed the backport/backport-9672-to-2.x branch from a768e0e to c737c9d Compare November 6, 2023 19:09
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator Author

reta commented Nov 6, 2023

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator Author

reta commented Nov 6, 2023

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator Author

reta commented Nov 7, 2023

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator Author

reta commented Nov 7, 2023

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator Author

reta commented Nov 7, 2023

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator Author

reta commented Nov 7, 2023

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator Author

reta commented Nov 7, 2023

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #11108 (c737c9d) into 2.x (7bf2a3a) will increase coverage by 0.06%.
Report is 6 commits behind head on 2.x.
The diff coverage is 56.50%.

@@             Coverage Diff              @@
##                2.x   #11108      +/-   ##
============================================
+ Coverage     70.98%   71.05%   +0.06%     
- Complexity    58932    58984      +52     
============================================
  Files          4851     4862      +11     
  Lines        278030   278391     +361     
  Branches      40766    40810      +44     
============================================
+ Hits         197357   197799     +442     
+ Misses        63916    63732     -184     
- Partials      16757    16860     +103     
Files Coverage Δ
...nsearch/http/netty4/Netty4HttpServerTransport.java 75.75% <ø> (ø)
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <ø> (ø)
...ava/org/opensearch/http/HttpTransportSettings.java 96.15% <100.00%> (+0.07%) ⬆️
...http/reactor/netty4/ReactorNetty4HttpResponse.java 85.71% <85.71%> (ø)
...ansport/reactor/netty4/ReactorNetty4Transport.java 75.00% <75.00%> (ø)
...reactor/netty4/ReactorNetty4HttpServerChannel.java 83.33% <83.33%> (ø)
...h/http/reactor/netty4/NonStreamingHttpChannel.java 66.66% <66.66%> (ø)
...tp/reactor/netty4/NonStreamingRequestConsumer.java 77.77% <77.77%> (ø)
...nsearch/transport/reactor/ReactorNetty4Plugin.java 7.69% <7.69%> (ø)
...search/http/reactor/netty4/HttpConversionUtil.java 26.31% <26.31%> (ø)
... and 4 more

... and 466 files with indirect coverage changes

@reta
Copy link
Collaborator Author

reta commented Nov 7, 2023

@dblock @andrross after N flaky builds, got a green one, mind please approving this backport? thank you

@dblock dblock merged commit bf599e3 into opensearch-project:2.x Nov 7, 2023
15 of 16 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-11108-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf599e3c33add09627c5dbc6820e9846efa2378a
# Push it to GitHub
git push --set-upstream origin backport/backport-11108-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-11108-to-2.x.

@reta reta removed the backport 2.x Backport to 2.x branch label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants