[Backport 2.x] Fix SuggestSearch.testSkipDuplicates by forceing refresh when indexing its test documents (#11068)

[peternied]

Description

During the testSkipDuplicates its possible that not all documents were fully indexed by the time the search with suggestions was created, updating the indexing operations to refresh the index before returning.

As its possible that did not fix the issue, I've added logging around the test case to capture the state when the error occurred that can assist in future troubleshooting.

Signed-off-by: Peter Nied petern@amazon.com
(cherry picked from commit 0ba5d58)

Related Issues

• Related [BUG] org.opensearch.search.suggest.CompletionSuggestSearchIT.testSkipDuplicates is flaky #10798

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change 1ee7fcd

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/29749/
• CommitID: 1e61939

[codecov]

Codecov Report

Merging #11141 (1ee7fcd) into 2.x (870ecd3) will decrease coverage by 0.05%.
Report is 7 commits behind head on 2.x.
The diff coverage is 56.63%.

@@             Coverage Diff              @@
##                2.x   #11141      +/-   ##
============================================
- Coverage     70.98%   70.93%   -0.05%     
- Complexity    58895    58957      +62     
============================================
  Files          4851     4862      +11     
  Lines        278023   278389     +366     
  Branches      40765    40809      +44     
============================================
+ Hits         197358   197488     +130     
- Misses        63872    64153     +281     
+ Partials      16793    16748      -45     

Files	Coverage Δ
...nsearch/http/netty4/Netty4HttpServerTransport.java	75.75% <ø> (ø)
...rg/opensearch/common/settings/ClusterSettings.java	92.85% <ø> (ø)
...ava/org/opensearch/http/HttpTransportSettings.java	96.15% <100.00%> (+0.07%)	⬆️
...http/reactor/netty4/ReactorNetty4HttpResponse.java	85.71% <85.71%> (ø)
...ansport/reactor/netty4/ReactorNetty4Transport.java	75.00% <75.00%> (ø)
...reactor/netty4/ReactorNetty4HttpServerChannel.java	83.33% <83.33%> (ø)
...g/opensearch/index/mapper/GeoShapeFieldMapper.java	80.00% <62.50%> (-3.64%)	⬇️
...h/http/reactor/netty4/NonStreamingHttpChannel.java	66.66% <66.66%> (ø)
...tp/reactor/netty4/NonStreamingRequestConsumer.java	77.77% <77.77%> (ø)
...nsearch/transport/reactor/ReactorNetty4Plugin.java	7.69% <7.69%> (ø)
... and 5 more

... and 480 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testDefaultBufferInterval

• URL: https://build.ci.opensearch.org/job/gradle-check/29782/
• CommitID: 1ee7fcd
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[peternied]

@reta or @mch2 could I get a review on this backport?