Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add indexRandomForConcurrentSearch for tests #11204

Merged
merged 6 commits into from
Nov 17, 2023

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Nov 14, 2023

Description

Manual backport for the following commits:

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ct#11118)

* IndexStatsIT.java
* SearchTimeoutIT.java
* NaNSortingIT.java
* NestedIT.java
* RangeIT.java

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Copy link
Contributor

github-actions bot commented Nov 14, 2023

Compatibility status:

Checks if related components are compatible with change bfddc44

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

❌ Gradle check result for bdf2a14: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 8bac796: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

* MultiSearchIT.java
* SimpleNestedIT.java
* SearchPreferenceIT.java
* SimpleQueryStringIT.java
* ScriptQuerySearchIT.java

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Copy link
Contributor

❌ Gradle check result for b8e5fc1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b8e5fc1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b8e5fc1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Gankris96 and others added 4 commits November 16, 2023 14:16
…ollow-up [opensearch-project#11130] (opensearch-project#11212)

Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
Signed-off-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
Signed-off-by: Ganesh Ramadurai <gramadur@amazon.com>
Co-authored-by: Ganesh Ramadurai <ganeshkrishna2396@gmail.com>
* Fixing the tests for concurrent search

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>

* Remove changes for non-flaky tests

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>

---------

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch
	    Remove unnecessary call to indexRandomForConcurrentSearch in testSearchAndRelocateConcurrently

Signed-off-by: Ethan Emoto <eemoto@amazon.com>
@jed326 jed326 marked this pull request as ready for review November 16, 2023 22:29
Copy link
Contributor

❕ Gradle check result for b8e5fc1: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadNonexistentBlobThrowsNoSuchFileException

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (827099e) 70.88% compared to head (bfddc44) 70.91%.
Report is 13 commits behind head on 2.x.

Files Patch % Lines
.../index/search/comparators/HalfFloatComparator.java 0.00% 29 Missing ⚠️
...eldcomparator/HalfFloatValuesComparatorSource.java 25.00% 12 Missing ⚠️
...rg/opensearch/gradle/OpenSearchTestBasePlugin.java 0.00% 4 Missing ⚠️
...g/opensearch/tools/launchers/SystemJvmOptions.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11204      +/-   ##
============================================
+ Coverage     70.88%   70.91%   +0.02%     
- Complexity    58926    58935       +9     
============================================
  Files          4862     4864       +2     
  Lines        278389   278443      +54     
  Branches      40806    40812       +6     
============================================
+ Hits         197336   197450     +114     
+ Misses        64289    64224      -65     
- Partials      16764    16769       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

✅ Gradle check result for bfddc44: SUCCESS

@sohami
Copy link
Collaborator

sohami commented Nov 17, 2023

Have manually set DCO to pass since I verified that each commit has the Signed-off-by line in it

@sohami sohami merged commit b33981e into opensearch-project:2.x Nov 17, 2023
17 of 18 checks passed
@jed326 jed326 deleted the backport-11181-11118 branch March 12, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants