-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to prevent segment fault errors arising due to unexpected SDK b… #11334
Fixes to prevent segment fault errors arising due to unexpected SDK b… #11334
Conversation
❌ Gradle check result for 78cfad7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
78cfad7
to
e8ef33c
Compare
❕ Gradle check result for e8ef33c: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
...c/main/java/org/opensearch/common/blobstore/transfer/stream/OffsetRangeIndexInputStream.java
Show resolved
Hide resolved
...c/main/java/org/opensearch/common/blobstore/transfer/stream/OffsetRangeIndexInputStream.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/opensearch/common/blobstore/transfer/stream/OffsetRangeIndexInputStream.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/blobstore/transfer/RemoteTransferContainer.java
Outdated
Show resolved
Hide resolved
d3d01bb
to
c671791
Compare
❌ Gradle check result for d3d01bb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11334 +/- ##
============================================
- Coverage 71.46% 71.42% -0.05%
+ Complexity 59176 59170 -6
============================================
Files 4903 4904 +1
Lines 277987 278147 +160
Branches 40382 40419 +37
============================================
- Hits 198662 198657 -5
- Misses 62805 62971 +166
+ Partials 16520 16519 -1 ☔ View full report in Codecov by Sentry. |
❌ Gradle check result for c671791: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 02637aa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
02637aa
to
29b8222
Compare
server/src/main/java/org/opensearch/common/blobstore/transfer/RemoteTransferContainer.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 29b8222: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
29b8222
to
d2713b4
Compare
❌ Gradle check result for d2713b4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vikasvb90. Please rebase this against the latest in main to fix the bwc test failure.
…ehaviour Signed-off-by: vikasvb90 <vikasvb@amazon.com>
…remove stream ownership from here Signed-off-by: vikasvb90 <vikasvb@amazon.com>
d2713b4
to
1d91527
Compare
❕ Gradle check result for 1d91527: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
opensearch-project#11334) Signed-off-by: vikasvb90 <vikasvb@amazon.com>
opensearch-project#11334) Signed-off-by: vikasvb90 <vikasvb@amazon.com>
opensearch-project#11334) Signed-off-by: vikasvb90 <vikasvb@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This PR adds guards against unexpected S3 SDK errors.
This is a forked PR from : #11327
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
New functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.