Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Optimizations in s3 async upload flow and guards against S3 async SDK… #11440

Merged
merged 1 commit into from
Dec 4, 2023
Merged

[Backport 2.x] Optimizations in s3 async upload flow and guards against S3 async SDK… #11440

merged 1 commit into from
Dec 4, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 77a4daf from #11327.

@github-actions
Optimizations in s3 async upload flow (#11327)
d20d097 
Signed-off-by: vikasvb90 <vikasvb@amazon.com>
(cherry picked from commit 77a4daf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Compatibility status:

Checks if related components are compatible with change d20d097

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

✅ Gradle check result for d20d097: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1f64349) 71.16% compared to head (d20d097) 71.07%.

Files Patch % Lines
...va/org/opensearch/repositories/s3/S3BlobStore.java 50.00% 3 Missing ⚠️
...a/org/opensearch/repositories/s3/S3Repository.java 50.00% 2 Missing ⚠️
...ch/repositories/s3/async/AsyncTransferManager.java 75.00% 1 Missing and 1 partial ⚠️
...rg/opensearch/repositories/s3/S3BlobContainer.java 96.55% 0 Missing and 1 partial ⚠️
...earch/repositories/s3/async/AsyncPartsHandler.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #11440      +/-   ##
============================================
- Coverage     71.16%   71.07%   -0.09%     
+ Complexity    59253    59186      -67     
============================================
  Files          4870     4870              
  Lines        278911   278961      +50     
  Branches      40876    40880       +4     
============================================
- Hits         198484   198280     -204     
- Misses        63634    63890     +256     
+ Partials      16793    16791       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 90c242c into 2.x Dec 4, 2023
43 of 69 checks passed
@github-actions github-actions bot deleted the backport/backport-11327-to-2.x branch December 4, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbbafna @vikasvb90