Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for conditional Transient header propagation #11490

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Add support for conditional Transient header propagation #11490

merged 10 commits into from
Jan 9, 2024

Conversation

Gaganjuneja
Copy link
Contributor

@Gaganjuneja Gaganjuneja commented Dec 6, 2023 •
edited
Loading

Description

Skips the Current_Span transient header propagation for the scheduled task. This was messing up with setting up the parent span.

Related Issues

Resolves #10291

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • [] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the enhancement Enhancement or improvement to existing feature or request label Dec 6, 2023
@Gaganjuneja
Copy link
Contributor Author

@reta, Please take a look.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change c5614ad

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git]

@peternied peternied dismissed their stale review January 8, 2024 14:38

@reta's callouts around deprecating the old values should go in with these changes

Refactor code
9b9a895 
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❌ Gradle check result for 9b9a895: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Refactor code
5697352 
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❌ Gradle check result for 5697352: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Supress warning
ad29c2e 
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❌ Gradle check result for ad29c2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Refactor code
c5614ad 
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❕ Gradle check result for c5614ad: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta
Copy link
Collaborator

reta commented Jan 8, 2024

@peternied looks good to you? thank you!

@peternied peternied mentioned this pull request Jan 9, 2024
Closed
@reta reta self-requested a review January 9, 2024 15:04
@peternied peternied mentioned this pull request Jan 9, 2024
Merged
8 tasks
@peternied
Copy link
Member

@reta Found an issue with the required-approval tool - fixed it and published a new version, after we merge [1] the update into main the min approval job can succeed

@reta reta merged commit 71f1fab into opensearch-project:main Jan 9, 2024
33 of 36 checks passed
@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 v2.12.0 Issues and PRs related to version 2.12.0 backport 2.x Backport to 2.x branch labels Jan 9, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 9, 2024
@github-actions @reta
Add support for conditional Transient header propagation (#11490)
71edb8d 
* Clear transient header from system context

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Clear transient header from system context

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds changelog

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Update CHANGELOG.md

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>

* Adds unit tests

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Supress warning

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
(cherry picked from commit 71f1fab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 9, 2024
Merged
reta added a commit that referenced this pull request Jan 9, 2024
@opensearch-trigger-bot @github-actions @reta
Add support for conditional Transient header propagation (#11490) (#1…
77d8964 
…1823)

* Clear transient header from system context



* Clear transient header from system context



* Adds changelog



* Update CHANGELOG.md




* Adds unit tests



* Refactor code



* Refactor code



* Refactor code



* Supress warning



* Refactor code



---------





(cherry picked from commit 71f1fab)

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
@BrewTestBot BrewTestBot mentioned this pull request Feb 21, 2024
Merged
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@Gaganjuneja @reta @rayshrey
Add support for conditional Transient header propagation (opensearch-…
0a79177 
…project#11490)

* Clear transient header from system context

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Clear transient header from system context

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds changelog

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Update CHANGELOG.md

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>

* Adds unit tests

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Supress warning

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@Gaganjuneja @reta @shiv0408
Add support for conditional Transient header propagation (opensearch-…
8aec65f 
…project#11490)

* Clear transient header from system context

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Clear transient header from system context

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds changelog

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Update CHANGELOG.md

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>

* Adds unit tests

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Supress warning

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternied peternied peternied approved these changes

@reta reta reta approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees

@peternied peternied

Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Indexing & Search v2.12.0 Issues and PRs related to version 2.12.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tracing Instrumentation] Add instrumentation at Local Transport Layer
3 participants
@Gaganjuneja @reta @peternied