Increase assertBusy timeout in flaky test testScrollCreatedOnReplica and add additional assertions #11730
Conversation
mch2
requested review from
abbashus,
adnapibar,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
setiah,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
mch2
changed the title
Compatibility status:Checks if related components are compatible with change 910c788 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/alerting.git] |
…Store#testScrollCreatedOnReplica This commit adds some additional assertions to testScrollCreatedOnReplica to try and identify cause of files remaining on disk. It also bumps the default assertBusy timeout from 10s to 30s to allow more time for file deletion. Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
|
❕ Gradle check result for 910c788: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11730 +/- ##
============================================
+ Coverage 71.25% 71.40% +0.14%
- Complexity 59139 59253 +114
============================================
Files 4909 4909
Lines 278427 278427
Branches 40460 40460
============================================
+ Hits 198397 198799 +402
+ Misses 63517 63164 -353
+ Partials 16513 16464 -49 ☔ View full report in Codecov by Sentry. |
...er/src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
Show resolved
Hide resolved
Description
This commit adds some additional assertions on the clear scroll response to testScrollCreatedOnReplica to try and identify cause of files remaining on disk. It also bumps the default assertBusy timeout from 10s to 30s to allow more time for file deletion.
Related Issues
Related #10769
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.