Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky RemoteFSTranslogTests testMetadataFileDeletion test #9605 #11899

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix flaky RemoteFSTranslogTests testMetadataFileDeletion test #9605 #11899

merged 1 commit into from
Jan 18, 2024

Conversation

ashking94
Copy link
Member

Description

This closes #9605. The flakiness in this test is on account of translog.trimUnreferencedReaders() being no-op when called due to previous deletion still ongoing and holding the permits. The current run of translog.trimUnreferencedReaders() on checking for permits sees that the required permits are not available and skips the deletion. To elaborate more on generation deletion, the approach is to acquire the permits, trigger async deletion and post successful deletion, release the permits. With this PR, I am making sure that after trimUnreferencedReaders(), we check that the required permits are available before calling the same method back again.

Related Issues

Resolves #9605

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working flaky-test Random test failure that succeeds on second run Storage:Remote labels Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change a63fa6a

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git]

@ashking94 ashking94 marked this pull request as ready for review January 16, 2024 15:01
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for a63fa6a: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c132db9) 71.33% compared to head (a63fa6a) 71.33%.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #11899   +/-   ##
=========================================
  Coverage     71.33%   71.33%           
+ Complexity    59300    59273   -27     
=========================================
  Files          4921     4921           
  Lines        278989   278989           
  Branches      40543    40543           
=========================================
+ Hits         199014   199027   +13     
+ Misses        63444    63375   -69     
- Partials      16531    16587   +56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashking94
Copy link
Member Author

❕ Gradle check result for a63fa6a: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Flaky test - #9191

deshsidd
deshsidd reviewed Jan 16, 2024
View reviewed changes
Copy link
Contributor

@deshsidd deshsidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many times did we run the test to see if the flakiness still persists?

@ashking94
Copy link
Member Author

How many times did we run the test to see if the flakiness still persists?

Had run it for 1K+ iterations on local. Running the entire class test suite for couple of hours more.

@ashking94
Copy link
Member Author

2K iterations have run without any failures.

@ashking94
Copy link
Member Author

3K iterations ran without any failures.

@sachinpkale sachinpkale merged commit 904c9a9 into opensearch-project:main Jan 18, 2024
110 of 114 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Jan 18, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 18, 2024
@github-actions
Fix flaky RemoteFSTranslogTests testMetadataFileDeletion test #9605 (#…
0de6f99 
…11899)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
(cherry picked from commit 904c9a9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 18, 2024
Merged
kotwanikunal pushed a commit that referenced this pull request Jan 24, 2024
@opensearch-trigger-bot @github-actions
Fix flaky RemoteFSTranslogTests testMetadataFileDeletion test #9605 (#…
fab16d7 
…11899) (#11915)

(cherry picked from commit 904c9a9)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
@ashking94
Fix flaky RemoteFSTranslogTests testMetadataFileDeletion test opensea…
604886f 
…rch-project#9605 (opensearch-project#11899)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@ashking94 @rayshrey
Fix flaky RemoteFSTranslogTests testMetadataFileDeletion test opensea…
a81a5de 
…rch-project#9605 (opensearch-project#11899)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@ashking94 @shiv0408
Fix flaky RemoteFSTranslogTests testMetadataFileDeletion test opensea…
96d7a1a 
…rch-project#9605 (opensearch-project#11899)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deshsidd deshsidd deshsidd left review comments

@sachinpkale sachinpkale sachinpkale approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run skip-changelog Storage:Remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Test RemoteFSTranslogTests.testMetadataFileDeletion is flaky
3 participants
@ashking94 @sachinpkale @deshsidd