Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Minio docker compose fixture #12014

Conversation

saratvemulapalli
Copy link
Member

@saratvemulapalli saratvemulapalli commented Jan 24, 2024

Description

While I was trying to run the S3 testRequestStats tests, Minio Fixture was seeing problems with docker-compose specifically with volumes having extended notation.

> Task :test:fixtures:minio-fixture:composeBuild FAILED
The Compose file './docker-compose.yml' is invalid because:
services.minio-fixture.volumes contains an invalid type, it should be a string
services.minio-fixture-for-snapshot-tool.volumes contains an invalid type, it should be a string
services.minio-fixture-other.volumes contains an invalid type, it should be a string

From docker docker/compose#4763, version 3.2 supports extended notations and it works!

Background: Was trying to fix #9859 and ended up on repository S3 test which was failing #10735 which has a test build dependency on minio-fixture (I do not know why though).

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change dabcaaa

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security.git]

@saratvemulapalli saratvemulapalli added the backport 2.x Backport to 2.x branch label Jan 24, 2024
Copy link
Contributor

❕ Gradle check result for dabcaaa: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1f8b16) 71.39% compared to head (dabcaaa) 71.40%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #12014   +/-   ##
=========================================
  Coverage     71.39%   71.40%           
+ Complexity    59404    59397    -7     
=========================================
  Files          4923     4923           
  Lines        279223   279223           
  Branches      40597    40597           
=========================================
+ Hits         199356   199369   +13     
+ Misses        63315    63226   -89     
- Partials      16552    16628   +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saratvemulapalli saratvemulapalli merged commit 76f7e73 into opensearch-project:main Jan 24, 2024
77 of 132 checks passed
@saratvemulapalli saratvemulapalli deleted the minio-fixture-volume-fix branch January 24, 2024 20:36
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 24, 2024
Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com>
(cherry picked from commit 76f7e73)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Jan 24, 2024
(cherry picked from commit 76f7e73)

Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testRequestStats is flaky
5 participants