-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Minio docker compose fixture #12014
Fixing Minio docker compose fixture #12014
Conversation
Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com>
Compatibility status:Checks if related components are compatible with change dabcaaa Incompatible componentsIncompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security.git] |
❕ Gradle check result for dabcaaa: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12014 +/- ##
=========================================
Coverage 71.39% 71.40%
+ Complexity 59404 59397 -7
=========================================
Files 4923 4923
Lines 279223 279223
Branches 40597 40597
=========================================
+ Hits 199356 199369 +13
+ Misses 63315 63226 -89
- Partials 16552 16628 +76 ☔ View full report in Codecov by Sentry. |
76f7e73
into
opensearch-project:main
Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com> (cherry picked from commit 76f7e73) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 76f7e73) Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com>
Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com>
Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
While I was trying to run the S3
testRequestStats
tests, Minio Fixture was seeing problems with docker-compose specifically with volumes having extended notation.From docker docker/compose#4763, version 3.2 supports extended notations and it works!
Background: Was trying to fix #9859 and ended up on repository S3 test which was failing #10735 which has a test build dependency on minio-fixture (I do not know why though).
Check List
Commit changes are listed out in CHANGELOG.md file (See: Changelog)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.