Do not request "search_pipelines" metrics by default in NodesInfoRequest #12497
Conversation
lukas-vlcek
requested review from
abbashus,
adnapibar,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
lukas-vlcek
force-pushed
the
defaultMetricsSet
branch
from
6997752 to
b04720a
Compare
|
❌ Gradle check result for 6997752: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b04720a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change dfe0e9a Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git] |
This commit introduces a breaking change: NodesInfoRequest does not request all metrics by default. There are metrics there are not included in the default set of metrics. Right now "search_pipelines" metric is not included in the default set of metrics. Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
lukas-vlcek
force-pushed
the
defaultMetricsSet
branch
from
b04720a to
dfe0e9a
Compare
|
The missing documentation part of this PR is "blocked" by opensearch-project/documentation-website#6544 (The documentation for |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12497 +/- ##
============================================
+ Coverage 71.37% 71.41% +0.03%
+ Complexity 59891 59886 -5
============================================
Files 4972 4972
Lines 281783 281800 +17
Branches 40910 40914 +4
============================================
+ Hits 201136 201251 +115
+ Misses 63977 63870 -107
- Partials 16670 16679 +9 ☔ View full report in Codecov by Sentry. |
…est (opensearch-project#12497) This commit introduces a breaking change: NodesInfoRequest does not request all metrics by default. There are metrics there are not included in the default set of metrics. Right now "search_pipelines" metric is not included in the default set of metrics. Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
…est (opensearch-project#12497) This commit introduces a breaking change: NodesInfoRequest does not request all metrics by default. There are metrics there are not included in the default set of metrics. Right now "search_pipelines" metric is not included in the default set of metrics. Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This commit introduces a breaking change:
NodesInfoRequest does not request all metrics by default.
There are metrics there are not included in the default set of metrics. Right now "search_pipelines" metric is not included in the default set of metrics.
Related Issues
Related issue: #10296
Originally, this change was part of above mentioned PR but during the review it was decided that it needs to be broken into several commits.
Check List
[ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.