-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce remote store path type in customData in IndexMetadata #12607
Conversation
❌ Gradle check result for 5e915e1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change fab0366 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git] |
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Created opensearch-project/documentation-website#6675 for documentation |
5e915e1
to
d256b66
Compare
❕ Gradle check result for d256b66: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Flaky test - #12338 |
Signed-off-by: Ashish Singh <ssashish@amazon.com>
48edb4e
to
25e06e9
Compare
❌ Gradle check result for 25e06e9: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test - #8928 |
❌ Gradle check result for 25e06e9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test - #12338 |
❌ Gradle check result for 25e06e9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Flaky test - #12717. The fix has been merged an hour ago. Rebased from main branch. |
❕ Gradle check result for fab0366: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
…search-project#12607) Signed-off-by: Ashish Singh <ssashish@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12607-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 91582e7c25a6f76eeebfa3ab74287178e1986491
# Push it to GitHub
git push --set-upstream origin backport/backport-12607-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Auto backport failed. Raising manual backport. |
…search-project#12607) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
…search-project#12607) Signed-off-by: Ashish Singh <ssashish@amazon.com>
…search-project#12607) Signed-off-by: Ashish Singh <ssashish@amazon.com>
…) (#13390) Signed-off-by: Ashish Singh <ssashish@amazon.com>
Description
In this PR, we introduce remote store path information which we will store in the IndexMatadata class and specifically customData field. This information will be useful in determining the path for a shard. User also gets the option to select the optimised approach versus the existing approach. We also get the extensibility option to further optimise it and change it for better resiliency, performance and throughput.
With this PR, we achieve the following things -
However, we need to handle couple of more things which I am adding to the meta issue :
Related Issues
Resolves #12608
Check List
Commit changes are listed out in CHANGELOG.md file (See: Changelog)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.