[segment replication] decouple the rateLimiter of segrep and recovery #12959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (12939) add setting "segrep.max_bytes_per_sec" Signed-off-by: maxliu <ly_chinese@163.com>
Ferrari248
requested review from
abbashus,
adnapibar,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
github-actions
bot
added
enhancement
|
❌ Gradle check result for 8b844fe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 25936fc: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Ferrari248
force-pushed
the
segrep-throttle
branch
from
25936fc to
9f1e604
Compare
|
This LGTM @Ferrari248 just one last thing - given this is a user facing change I think we should add a changelog entry. Would you please update changelog.md here? |
…opensearch-project#12939) add setting "indices.replication.max_bytes_per_sec" which takes effect when not negative Signed-off-by: maxliu <ly_chinese@163.com> Adds change log Signed-off-by: maxliu <ly_chinese@163.com>
Ferrari248
force-pushed
the
segrep-throttle
branch
from
9f1e604 to
8c1a6ce
Compare
Thanks for review. Done. |
|
❕ Gradle check result for 4f63511: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Ferrari248
force-pushed
the
segrep-throttle
branch
from
4f63511 to
055765c
Compare
|
❕ Gradle check result for 055765c: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Ferrari248
force-pushed
the
segrep-throttle
branch
from
055765c to
47577b0
Compare
|
❌ Gradle check result for 47577b0: TIMEOUT Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: maxliu <ly_chinese@163.com>
Ferrari248
force-pushed
the
segrep-throttle
branch
from
47577b0 to
fedc06c
Compare
mch2
approved these changes
Apr 12, 2024
4 tasks
|
added docs issue - opensearch-project/documentation-website#6948 |
mch2
added
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 14, 2024
…#12959) * [segment replication] decouple the rateLimiter of segrep and recovery (12939) add setting "segrep.max_bytes_per_sec" Signed-off-by: maxliu <ly_chinese@163.com> * [segment replication] decouple the rateLimiter of segrep and recovery (12939) use setting "indices.replication.max_bytes_per_sec" if enable "indices.replication.use_individual_rate_limiter" Signed-off-by: maxliu <ly_chinese@163.com> * [segment replication] decouple the rateLimiter of segrep and recovery (12939) setting "indices.replication.max_bytes_per_sec" takes effect when not negative Signed-off-by: maxliu <ly_chinese@163.com> * [segment replication] decouple the rateLimiter of segrep and recovery (#12939) add setting "indices.replication.max_bytes_per_sec" which takes effect when not negative Signed-off-by: maxliu <ly_chinese@163.com> Adds change log Signed-off-by: maxliu <ly_chinese@163.com> --------- Signed-off-by: maxliu <ly_chinese@163.com> (cherry picked from commit 6bc04b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2
pushed a commit
that referenced
this pull request
Apr 15, 2024
…#12959) * [segment replication] decouple the rateLimiter of segrep and recovery (12939) add setting "segrep.max_bytes_per_sec" Signed-off-by: maxliu <ly_chinese@163.com> * [segment replication] decouple the rateLimiter of segrep and recovery (12939) use setting "indices.replication.max_bytes_per_sec" if enable "indices.replication.use_individual_rate_limiter" Signed-off-by: maxliu <ly_chinese@163.com> * [segment replication] decouple the rateLimiter of segrep and recovery (12939) setting "indices.replication.max_bytes_per_sec" takes effect when not negative Signed-off-by: maxliu <ly_chinese@163.com> * [segment replication] decouple the rateLimiter of segrep and recovery (#12939) add setting "indices.replication.max_bytes_per_sec" which takes effect when not negative Signed-off-by: maxliu <ly_chinese@163.com> Adds change log Signed-off-by: maxliu <ly_chinese@163.com> --------- Signed-off-by: maxliu <ly_chinese@163.com> (cherry picked from commit 6bc04b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2
added a commit
that referenced
this pull request
Apr 15, 2024
…ep and recovery (#13181) * [segment replication] decouple the rateLimiter of segrep and recovery (#12959) * [segment replication] decouple the rateLimiter of segrep and recovery (12939) add setting "segrep.max_bytes_per_sec" Signed-off-by: maxliu <ly_chinese@163.com> * [segment replication] decouple the rateLimiter of segrep and recovery (12939) use setting "indices.replication.max_bytes_per_sec" if enable "indices.replication.use_individual_rate_limiter" Signed-off-by: maxliu <ly_chinese@163.com> * [segment replication] decouple the rateLimiter of segrep and recovery (12939) setting "indices.replication.max_bytes_per_sec" takes effect when not negative Signed-off-by: maxliu <ly_chinese@163.com> * [segment replication] decouple the rateLimiter of segrep and recovery (#12939) add setting "indices.replication.max_bytes_per_sec" which takes effect when not negative Signed-off-by: maxliu <ly_chinese@163.com> Adds change log Signed-off-by: maxliu <ly_chinese@163.com> --------- Signed-off-by: maxliu <ly_chinese@163.com> (cherry picked from commit 6bc04b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add back public API in RecoverySettings to 2.x Signed-off-by: Marc Handalian <marc.handalian@gmail.com> --------- Signed-off-by: maxliu <ly_chinese@163.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Marc Handalian <marc.handalian@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add setting
indices.replication.max_bytes_per_secspecially for segment replication, to decouple the rateLimiter of segment replication and recovery.Related Issues
Resolves #12939
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.