-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Update index settings on shard movement during remote store migration #13316
[Remote Store] Update index settings on shard movement during remote store migration #13316
Conversation
❌ Gradle check result for f14e231: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ca4b1d9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 667cffe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
cae1886
to
aa83dc3
Compare
❌ Gradle check result for cae1886: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 6f9f0c3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/cluster/routing/allocation/IndexMetadataUpdater.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
❌ Gradle check result for 98004f8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
bc6d493
to
e4ce087
Compare
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
❌ Gradle check result for e4ce087: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for bc6d493: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 455bc59: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❌ Gradle check result for 1179072: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
❌ Gradle check result for 4d37794: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
❌ Gradle check result for a19c5cd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test being fixed through: #13457 |
…store migration (#13316) (#13466) (cherry picked from commit 1f406db) Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…store migration (opensearch-project#13316) Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
…store migration (opensearch-project#13316) Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Description
Reopening this since #13253 got closed during a rebase from main
The
IndexMetadataUpdater
logic runs on the cluster manager and applies changes in shard state triggered byAllocationService
. Depending on the state of the shard afterAllocationService
decisions, theIndexMetadataUpdater
would currently do stuff like update in-sync allocation IDs or bump primary terms in theIndexMetadata
which is the cluster manager then publishes to the data nodes as a state update. TheIndicesClusterStateService
responds to these changes and then performs relevant actions like creating or updating the existingIndexShard
instance. We are utilizing this code path and adding logic within theIndexMetadataUpdater
to:Currently this logic would only execute when the cluster is in mixed mode and direction for migration is
remote_store
Since the updated metadata would be handed over from the cluster manager to the data nodes during a state publication, this helps us in:
and
Apart from this:
RemoteDualReplicationIT
to accommodate the changes being introduced through this PRstrict
frommixed
mode if all indices in the cluster does not have the remote store based settings.Related Issues
Resolves #13252
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.