-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Async Batch shards changes for GatewayAllocator #13431
[Backport 2.x] Async Batch shards changes for GatewayAllocator #13431
Conversation
) Changes for create/update/delete batches for batch mode for async fetch for both primary & replica. It also added the node scope setting to enable/ disable batch mode. Signed-off-by: Gaurav Chandani <chngau@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> Signed-off-by: Aman Khare <amkhar@amazon.com> (cherry picked from commit a69cd08)
❌ Gradle check result for 0a8b6ff: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
❌ Gradle check result for bc1660f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@shiv0408 we will need documentation PR for the new settings as well |
❌ Gradle check result for bc1660f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
❕ Gradle check result for 0eca30f: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #13431 +/- ##
============================================
- Coverage 71.28% 71.23% -0.05%
- Complexity 60145 60891 +746
============================================
Files 4957 5021 +64
Lines 282799 286714 +3915
Branches 41409 41896 +487
============================================
+ Hits 201591 204239 +2648
- Misses 64189 65270 +1081
- Partials 17019 17205 +186 ☔ View full report in Codecov by Sentry. |
Changes for create/update/delete batches for batch mode for async fetch for both primary & replica. It also added the node scope setting to enable/ disable batch mode.
Signed-off-by: Gaurav Chandani chngau@amazon.com
Signed-off-by: Shivansh Arora hishiv@amazon.com
Signed-off-by: Aman Khare amkhar@amazon.com
(cherry picked from commit a69cd08 from #8746)