Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading netty version to 4.1.69.Final #1363

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

VachaShah
Copy link
Collaborator

Signed-off-by: Vacha vachshah@amazon.com

Description

Upgraded netty version from 4.1.59.Final to 4.1.69.Final which updates the following dependencies:

  • io.netty:netty-buffer
  • io.netty:netty-codec
  • io.netty:netty-codec-http
  • io.netty:netty-common
  • io.netty:netty-handler
  • io.netty:netty-resolver
  • io.netty:netty-transport

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 9f0861eeb8c1b3d2763d392fc8dd4ec964a9c0ab

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 9f0861eeb8c1b3d2763d392fc8dd4ec964a9c0ab

Signed-off-by: Vacha <vachshah@amazon.com>
@tlfeng tlfeng added CVE Fixes a CVE v1.2.0 Issues related to version 1.2.0 v2.0.0 Version 2.0.0 labels Oct 13, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success f533683

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed f533683

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 9f0861eeb8c1b3d2763d392fc8dd4ec964a9c0ab

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success f533683

@dblock
Copy link
Member

dblock commented Oct 13, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f533683
Log 685

Reports 685

@VachaShah
Copy link
Collaborator Author

VachaShah commented Oct 13, 2021

Error in gradle check:

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests.testReplicaThreadedThroughputDegradationAndRejection" -Dtests.seed=2ED032DE0AAADA1B -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1" -Dtests.locale=pt -Dtests.timezone=Australia/Victoria -Druntime.java=17
  2> java.lang.AssertionError: expected:<1> but was:<4>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:645)
        at org.junit.Assert.assertEquals(Assert.java:631)
        at org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests.testReplicaThreadedThroughputDegradationAndRejection(ShardIndexingPressureConcurrentExecutionTests.java:506)

    com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=1161, name=Thread-982, state=RUNNABLE, group=TGRP-ShardIndexingPressureConcurrentExecutionTests]

        Caused by:
        org.opensearch.common.util.concurrent.OpenSearchRejectedExecutionException: rejected execution of replica operation [shard_detail=[IndexName][0], shard_total_bytes=11200, shard_operation_bytes=100, shard_max_coordinating_and_primary_bytes=10, shard_max_replica_bytes=13294] OR [node_total_bytes=11200, node_operation_bytes=100, node_max_coordinating_and_primary_bytes=10240, node_max_replica_bytes=15360]
            at __randomizedtesting.SeedInfo.seed([2ED032DE0AAADA1B]:0)
            at org.opensearch.index.ShardIndexingPressure.rejectShardRequest(ShardIndexingPressure.java:286)
            at org.opensearch.index.ShardIndexingPressure.markReplicaOperationStarted(ShardIndexingPressure.java:179)
            at org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests.lambda$fireConcurrentAndParallelRequestsForUniformThroughPut$13(ShardIndexingPressureConcurrentExecutionTests.java:834)

Issue for the bug: #1361

@VachaShah
Copy link
Collaborator Author

The fix is merged, @dblock can we retry the gradle check?

@dblock
Copy link
Member

dblock commented Oct 15, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success f533683
Log 700

Reports 700

@VachaShah
Copy link
Collaborator Author

@dblock Can we merge this PR? I will create backport PRs after that. Thank you!

@dblock dblock merged commit c7f5c90 into opensearch-project:main Oct 18, 2021
@dblock dblock added the pending backport Identifies an issue or PR that still needs to be backported label Oct 18, 2021
@VachaShah VachaShah deleted the upgrade-netty branch October 18, 2021 21:41
VachaShah added a commit to VachaShah/OpenSearch that referenced this pull request Oct 18, 2021
Signed-off-by: Vacha <vachshah@amazon.com>
VachaShah added a commit to VachaShah/OpenSearch that referenced this pull request Oct 18, 2021
Signed-off-by: Vacha <vachshah@amazon.com>
@VachaShah
Copy link
Collaborator Author

Backport PR 1.x #1382
Backport PR 1.1 #1383

dblock pushed a commit that referenced this pull request Oct 19, 2021
Signed-off-by: Vacha <vachshah@amazon.com>
dblock pushed a commit that referenced this pull request Oct 19, 2021
Signed-off-by: Vacha <vachshah@amazon.com>
@VachaShah VachaShah removed the pending backport Identifies an issue or PR that still needs to be backported label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CVE Fixes a CVE v1.2.0 Issues related to version 1.2.0 v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants