De-duping shards in ShardsBatchGatewayAllocator based on ShardId inst… #13710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13710 +/- ##
============================================
+ Coverage 71.42% 71.57% +0.15%
- Complexity 59978 61274 +1296
============================================
Files 4985 5060 +75
Lines 282275 287856 +5581
Branches 40946 41689 +743
============================================
+ Hits 201603 206023 +4420
- Misses 63999 64817 +818
- Partials 16673 17016 +343 ☔ View full report in Codecov by Sentry. |
shiv0408
approved these changes
May 17, 2024
There was a problem hiding this comment.
Changes look good in perspective of fixing the bug @rajiv-kv. Can we have a follow up issue where we can look into the optimization where if there multiple replicas of a shard, we don't need n round of reroutes/fetches to get them assigned? It would be good to see that optimization in future.
rajiv-kv
force-pushed
the
async-fetch-bug-fix
branch
from
85a748d to
e4c0cc6
Compare
rajiv-kv
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
|
❌ Gradle check result for e4c0cc6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
sachinpkale
reviewed
May 20, 2024
server/src/main/java/org/opensearch/gateway/ShardsBatchGatewayAllocator.java
Show resolved
Hide resolved
…ead of ShardRouting#equals Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
rajiv-kv
force-pushed
the
async-fetch-bug-fix
branch
from
e4c0cc6 to
8ee9ae4
Compare
sachinpkale
approved these changes
May 22, 2024
rajiv-kv
pushed a commit
to rajiv-kv/OpenSearch
that referenced
this pull request
Jun 10, 2024
…ead of ShardRouting#equals (opensearch-project#13710) Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
Merged
3 tasks
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
…ead of ShardRouting#equals (opensearch-project#13710) Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
3 tasks
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…ead of ShardRouting#equals (opensearch-project#13710) (opensearch-project#14111) Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ShardsBatchGatewayAllocator de-dupes the unassigned Shards based on ShardRouting. If index is configured with muliple replicas, there will be multiple ShardRouting entries for same replica shard. The equals comparison of ShardRouting includes comparison based on <ShardMetada, UnassignedInfo>. This can cause incorrect de-duplication if UnassignedInfo is different for Replica copies. Hence changing the implementation to de-dupe based on ShardId, so that only one entry is created in cache and there are no duplicate entries across batches.
Related Issues
Resolves #[13705]
Check List
API changes companion pull request created.Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.