Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing RemoteStorePathStrategy to internal as it is not supposed to… #13749

Closed
wants to merge 1 commit into from

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented May 20, 2024

… be used by plugins

Description

RemoteStorePathStrategy is an internal API and is not supposed by to used/modified/extended by plugins .

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… be used by plugins

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Copy link
Contributor

❌ Gradle check result for 9e14b0a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna gbbafna changed the title Changing RemoteStorePathStrategy to internal as it is not supposed to… [Do not merge]Changing RemoteStorePathStrategy to internal as it is not supposed to… May 20, 2024
@gbbafna gbbafna changed the title [Do not merge]Changing RemoteStorePathStrategy to internal as it is not supposed to… [Do not merge] Changing RemoteStorePathStrategy to internal as it is not supposed to… May 20, 2024
@gbbafna gbbafna changed the title [Do not merge] Changing RemoteStorePathStrategy to internal as it is not supposed to… Changing RemoteStorePathStrategy to internal as it is not supposed to… May 20, 2024
Copy link
Contributor

❌ Gradle check result for 9e14b0a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna gbbafna closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant