Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store Migration] Handling translog metadata update during remote store migration #13810

Closed

Conversation

shourya035
Copy link
Member

@shourya035 shourya035 commented May 24, 2024

Description

Wiring RespositoriesService to IndexMigrationUpdater from ClusterModule through AllocationService. This is being utilized during remote store migration flow to determine if the translog repository supports the newly introduced tlog metadata in object metadata feature #13091

Related Issues

Resolves #13745

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Remote labels May 24, 2024
@shourya035 shourya035 added skip-changelog and removed enhancement Enhancement or improvement to existing feature or request Storage:Remote labels May 24, 2024
@shourya035 shourya035 self-assigned this May 24, 2024
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Remote labels May 24, 2024
Copy link
Contributor

❌ Gradle check result for e09d1f8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for c00a803: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7d7dd50: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shourya035 shourya035 force-pushed the tlog-md-during-migration branch from 7d7dd50 to b470ddb Compare May 31, 2024 12:10
Copy link
Contributor

❌ Gradle check result for b470ddb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shourya035 shourya035 force-pushed the tlog-md-during-migration branch from ea8de1f to e176d48 Compare June 3, 2024 09:21
Copy link
Contributor

github-actions bot commented Jun 3, 2024

❕ Gradle check result for ea8de1f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 65.38462% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 71.67%. Comparing base (b15cb0c) to head (eea6ff7).
Report is 335 commits behind head on main.

Files Patch % Lines
.../org/opensearch/index/remote/RemoteStoreUtils.java 53.84% 2 Missing and 4 partials ⚠️
.../cluster/routing/allocation/RoutingAllocation.java 62.50% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13810      +/-   ##
============================================
+ Coverage     71.42%   71.67%   +0.25%     
- Complexity    59978    61313    +1335     
============================================
  Files          4985     5065      +80     
  Lines        282275   288144    +5869     
  Branches      40946    41723     +777     
============================================
+ Hits         201603   206535    +4932     
- Misses        63999    64515     +516     
- Partials      16673    17094     +421     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

❌ Gradle check result for e176d48: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
@shourya035 shourya035 force-pushed the tlog-md-during-migration branch from e176d48 to 23549ad Compare June 3, 2024 11:00
@shourya035 shourya035 marked this pull request as ready for review June 3, 2024 11:01
Copy link
Contributor

github-actions bot commented Jun 3, 2024

❌ Gradle check result for 23549ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ Gradle check result for eea6ff7: SUCCESS

@gbbafna
Copy link
Collaborator

gbbafna commented Jun 6, 2024

We are not planning for this change anymore. Closing it .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request skip-changelog Storage:Remote
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Handle remote store custom metadata during docrep to remote migration
2 participants