-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Add X-Opaque-Id to search request metadata for query insights (#13374) #14078
[Backport 2.x] Add X-Opaque-Id to search request metadata for query insights (#13374) #14078
Conversation
…arch-project#13374) --------- Signed-off-by: Chenyang Ji <cyji@amazon.com> (cherry picked from commit 9d3cf43) Signed-off-by: Chenyang Ji <cyji@amazon.com>
❕ Gradle check result for dcb30c3: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #14078 +/- ##
============================================
+ Coverage 71.28% 71.39% +0.11%
- Complexity 60145 61497 +1352
============================================
Files 4957 5045 +88
Lines 282799 289021 +6222
Branches 41409 42211 +802
============================================
+ Hits 201591 206359 +4768
- Misses 64189 65287 +1098
- Partials 17019 17375 +356 ☔ View full report in Codecov by Sentry. |
I think there might be some thread context related failures on main so let's get to the bottom of that first: https://build.ci.opensearch.org/job/gradle-check/40215/testReport/junit/org.opensearch.recovery/RelocationIT/testIndexSearchAndRelocateConcurrently__p0___cluster_indices_replication_strategy___SEGMENT___/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be causing any of the test failures as all the changes are in the query plugins insight which isn't being enabled in the tests. The culprit is probably this one: #13172
Fixed the test failure in #14084 |
…arch-project#13374) (opensearch-project#14078) --------- (cherry picked from commit 9d3cf43) Signed-off-by: Chenyang Ji <cyji@amazon.com> Signed-off-by: kkewwei <kkewwei@163.com>
Manual backport PR for #13374
(cherry picked from commit 9d3cf43)
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.