[bug fix] validate lower bound for top n size

[ansjcy]

Description

Currently the top n size can be set to a negative number. We want to limit top size between 1 and QueryInsightsSettings.MAX_N_SIZE.

curl -X PUT 'localhost:9200/_cluster/settings' -H 'Content-Type: application/json' -d'
{
    "persistent" : {
        "search.insights.top_queries.latency.top_n_size" : -1
    }
}'
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"illegal value can't update [search.insights.top_queries.latency.top_n_size] from [3] to [-1]"}],"type":"illegal_argument_exception","reason":"illegal value can't update [search.insights.top_queries.latency.top_n_size] from [3] to [-1]","caused_by":{"type":"illegal_argument_exception","reason":"Top N size setting for [latency] should be between 1 and 100, was (-1)"}},"status":400}

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 1b2c872: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for ad41484: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for ad41484: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 3856b76: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[dbwiddis]

LGTM!

[github-actions]

❌ Gradle check result for cc271b2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[ansjcy]

Tried rebuilding for several times, still failing on SimpleClusterStateIT/testMetadataVersion

[github-actions]

✅ Gradle check result for 9e87b50: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.63%. Comparing base (0684342) to head (9e87b50).

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #14587      +/-   ##
============================================
- Coverage     71.68%   71.63%   -0.05%     
+ Complexity    62365    62355      -10     
============================================
  Files          5148     5148              
  Lines        293297   293297              
  Branches      42384    42384              
============================================
- Hits         210239   210097     -142     
- Misses        65717    65868     +151     
+ Partials      17341    17332       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.