Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Bugfix] Fix ICacheKeySerializerTests flakiness #14617

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[Backport 2.x] [Bugfix] Fix ICacheKeySerializerTests flakiness #14617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions server/src/test/java/org/opensearch/common/cache/serializer/ICacheKeySerializerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,9 @@ public void testInvalidInput() throws Exception {
ICacheKeySerializer<BytesReference> serializer = new ICacheKeySerializer<>(keySer);

Random rand = Randomness.get();
byte[] randomInput = new byte[1000];
rand.nextBytes(randomInput);

assertThrows(OpenSearchException.class, () -> serializer.deserialize(randomInput));
// The first thing the serializer reads is a VInt for the number of dimensions.
// This is an invalid input for StreamInput.readVInt(), so we are guaranteed to have an exception
assertThrows(OpenSearchException.class, () -> serializer.deserialize(new byte[] { -1, -1, -1, -1, -1 }));
}

public void testDimNumbers() throws Exception {
Expand Down
Loading