Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.16] [Backport 2.x] Add SplitResponseProcessor to Search Pipelines #14867

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[Backport 2.16] [Backport 2.x] Add SplitResponseProcessor to Search Pipelines #14867

merged 1 commit into from
Jul 22, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3b0ea65 from #14863.

@github-actions
Add SplitResponseProcessor to Search Pipelines (#14800) (#14863)
30e590a 
* Add SplitResponseProcessor for search pipelines

* Register the split processor factory

* Address code review comments

* Avoid list copy by casting array

---------

(cherry picked from commit 45c5f8d)

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 3b0ea65)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 30e590a: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.60%. Comparing base (7755055) to head (30e590a).

Files Patch % Lines
...search/pipeline/common/SplitResponseProcessor.java 92.85% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               2.16   #14867      +/-   ##
============================================
+ Coverage     71.58%   71.60%   +0.01%     
- Complexity    62544    62574      +30     
============================================
  Files          5108     5109       +1     
  Lines        293645   293687      +42     
  Branches      42781    42791      +10     
============================================
+ Hits         210205   210283      +78     
- Misses        65741    65782      +41     
+ Partials      17699    17622      -77

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 82cb703 into 2.16 Jul 22, 2024
52 checks passed
@dbwiddis dbwiddis deleted the backport/backport-14863-to-2.16 branch July 22, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dbwiddis