Fix derived field tests for percentile ranks. #15015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests fail to backport to 2.x becuase 2.x uses a different branch of tdigest that computes percentiles differently. Rather than chase these over time, change the assertions to check for the length of results returned instead of their values. Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
mch2
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
Should we backport only this to 2.x instead? Or are you saying that the |
jed326
approved these changes
Jul 29, 2024
Yeah, I didn't want this to be an issue down the line given the actual percentiles are not coming from our code. |
|
❕ Gradle check result for 65f8f20: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15015 +/- ##
============================================
- Coverage 71.89% 71.09% -0.80%
+ Complexity 62756 62091 -665
============================================
Files 5161 5161
Lines 294402 294368 -34
Branches 42582 42577 -5
============================================
- Hits 211654 209290 -2364
- Misses 65324 67597 +2273
- Partials 17424 17481 +57 ☔ View full report in Codecov by Sentry. |
mch2
added a commit
that referenced
this pull request
Jul 30, 2024
These tests fail to backport to 2.x becuase 2.x uses a different branch of tdigest that computes percentiles differently. Rather than chase these over time, change the assertions to check for the length of results returned instead of their values. Signed-off-by: Marc Handalian <marc.handalian@gmail.com> (cherry picked from commit 0cde7ba) Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
mch2
added a commit
that referenced
this pull request
Jul 30, 2024
…ields (#15009) * [Derived Fields] Add aggregation support for derived fields (#14618) * Add aggregation support for derived fields Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * add unit test for a terms agg with derived fields Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Fix license header and add changelog entry Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * move matrix_stats tests to aggs-matrix-stats module Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Move matrix tests back and add dependency to painless module Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * add tests for all aggregations types and support ip_range Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Add tests for agg script returned from DerivedFieldType Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * remove children aggs test as its not yet supported Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Add more tests Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * fix changelog Signed-off-by: Marc Handalian <marc.handalian@gmail.com> --------- Signed-off-by: Marc Handalian <marc.handalian@gmail.com> (cherry picked from commit e26608b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix derived field tests for percentile ranks. (#15015) These tests fail to backport to 2.x becuase 2.x uses a different branch of tdigest that computes percentiles differently. Rather than chase these over time, change the assertions to check for the length of results returned instead of their values. Signed-off-by: Marc Handalian <marc.handalian@gmail.com> (cherry picked from commit 0cde7ba) Signed-off-by: Marc Handalian <marc.handalian@gmail.com> --------- Signed-off-by: Marc Handalian <marc.handalian@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Aug 20, 2024
These tests fail to backport to 2.x becuase 2.x uses a different branch of tdigest that computes percentiles differently. Rather than chase these over time, change the assertions to check for the length of results returned instead of their values. Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
These tests fail to backport to 2.x becuase 2.x uses a different branch of tdigest that computes percentiles differently. Rather than chase these over time, change the assertions to check for the length of results returned instead of their values. Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix derived field tests for percentile ranks.
These tests fail to backport to 2.x becuase 2.x uses a different branch of
tdigest that computes percentiles differently. Rather than chase these over time,
change the assertions to check for the length of results returned instead of their values.
Related Issues
Resolves N/A - caught while backporting this pr #15009 to 2.x, will include this commit with the backport after it lands in main.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.