Fix typo super->sb in method toString() of RemoteStoreNodeAttribute

[dk2k]

Removed unused StringBuilder

[github-actions]

❌ Gradle check result for 2d1830c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[dblock]

Same comment as #15360 (comment) please.

[dbwiddis]

The result of this change is to override Object.toString() to return Object.toString(). If that were the case, deleting the method would be better.

But it seems clear that super is intended to be sb here.

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[github-actions]

✅ Gradle check result for da78728: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.04%. Comparing base (f1c98a4) to head (da78728).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...rch/node/remotestore/RemoteStoreNodeAttribute.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15362      +/-   ##
============================================
+ Coverage     71.98%   72.04%   +0.06%     
- Complexity    64810    64823      +13     
============================================
  Files          5307     5308       +1     
  Lines        302719   302727       +8     
  Branches      43734    43734              
============================================
+ Hits         217912   218100     +188     
+ Misses        66915    66729     -186     
- Partials      17892    17898       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dbwiddis]

LGTM!

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15362-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0419e5d8a5b5327663c09e93feb931281da7b64e
# Push it to GitHub
git push --set-upstream origin backport/backport-15362-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15362-to-2.x.

[dbwiddis]

Created the backport. @dk2k please help us out here; while you are correctly signing your commits with DCO (thank you) your GitHub commits are coming from a "noreply" address, and when we backport to the 2.x branch the DCO is failing due to the "Author address" mismatch. Please update your GitHub profile to use the same address you're signing your DCO commits with.