-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing order field in TemplatesMetadata deserialization #15509
Conversation
server/src/main/java/org/opensearch/cluster/metadata/TemplatesMetadata.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for ed48b59: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
ed48b59
to
0915cb4
Compare
❌ Gradle check result for 0915cb4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
0915cb4
to
8e7b724
Compare
❕ Gradle check result for 8e7b724: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15509 +/- ##
============================================
- Coverage 71.92% 71.92% -0.01%
- Complexity 63483 63496 +13
============================================
Files 5244 5244
Lines 296911 296910 -1
Branches 42879 42879
============================================
- Hits 213557 213552 -5
- Misses 65799 65837 +38
+ Partials 17555 17521 -34 ☔ View full report in Codecov by Sentry. |
server/src/test/java/org/opensearch/gateway/remote/model/RemoteTemplatesMetadataTests.java
Show resolved
Hide resolved
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
8e7b724
to
de02738
Compare
❕ Gradle check result for de02738: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Sooraj Sinha <soosinha@amazon.com> (cherry picked from commit bcd09ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…rch-project#15509) Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
…rch-project#15509) Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
…rch-project#15509) Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
…rch-project#15509) Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Description
order
field is missing while deserializing TemplatesMetadata object. This is because it is the first field in the serialized content and we are moving to the next token just before deserialization.Related Issues
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.