Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing order field in TemplatesMetadata deserialization #15509

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

soosinha
Copy link
Member

Description

order field is missing while deserializing TemplatesMetadata object. This is because it is the first field in the serialized content and we are moving to the next token just before deserialization.

Related Issues

NA

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for ed48b59: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 0915cb4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 8e7b724: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.gateway.RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.92%. Comparing base (e146f13) to head (de02738).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
...opensearch/cluster/metadata/TemplatesMetadata.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15509      +/-   ##
============================================
- Coverage     71.92%   71.92%   -0.01%     
- Complexity    63483    63496      +13     
============================================
  Files          5244     5244              
  Lines        296911   296910       -1     
  Branches      42879    42879              
============================================
- Hits         213557   213552       -5     
- Misses        65799    65837      +38     
+ Partials      17555    17521      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Copy link
Contributor

❕ Gradle check result for de02738: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@Bukhtawar Bukhtawar added skip-changelog backport 2.x Backport to 2.x branch labels Sep 2, 2024
@Bukhtawar Bukhtawar merged commit bcd09ab into opensearch-project:main Sep 3, 2024
41 of 44 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
(cherry picked from commit bcd09ab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Sep 3, 2024
…#15591)

(cherry picked from commit bcd09ab)

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@soosinha soosinha deleted the templates-bug branch December 20, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants