[Backport 2.x] add request failure listener to track failures at query group level (#15527) #15539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oject#15527) * add workload managementRequestFailureListener Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add unit tests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add CHANGELOG Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add missing javadoc Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename listener instance Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
kaushalmahi12
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
msfroh
changed the title
|
❌ Gradle check result for c9d0e76: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #15539 +/- ##
============================================
- Coverage 71.73% 71.58% -0.15%
+ Complexity 63721 63679 -42
============================================
Files 5235 5235
Lines 297971 298158 +187
Branches 43363 43411 +48
============================================
- Hits 213741 213433 -308
- Misses 66369 66894 +525
+ Partials 17861 17831 -30 ☔ View full report in Codecov by Sentry. |
jainankitk
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR for #15527