Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version check for context to comply with backport #15572

Merged

Conversation

mgodwan
Copy link
Member

@mgodwan mgodwan commented Sep 2, 2024

Description

Fix for version check after merging #15530

Related Issues

[Resolves #[Issue number to be closed when this PR is merged]

](https://github.com//issues/14649)

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for 1d00a68: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan mgodwan force-pushed the forward-port-version-check branch 2 times, most recently from 63e34d3 to 9c8d702 Compare September 2, 2024 13:26
@mgodwan mgodwan force-pushed the forward-port-version-check branch from 9c8d702 to 07f0c42 Compare September 2, 2024 14:20
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for 07f0c42: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan mgodwan force-pushed the forward-port-version-check branch from 07f0c42 to 472f86b Compare September 2, 2024 14:23
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for 472f86b: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan mgodwan force-pushed the forward-port-version-check branch from 472f86b to bfecbfc Compare September 2, 2024 14:31
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for bfecbfc: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for 9c8d702: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan mgodwan force-pushed the forward-port-version-check branch from bfecbfc to fac50bb Compare September 2, 2024 14:40
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for 63e34d3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for fac50bb: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@mgodwan mgodwan force-pushed the forward-port-version-check branch from fac50bb to 840fefb Compare September 2, 2024 16:53
@bharath-techie bharath-techie mentioned this pull request Sep 2, 2024
3 tasks
Copy link
Contributor

github-actions bot commented Sep 2, 2024

✅ Gradle check result for 840fefb: SUCCESS

@sachinpkale sachinpkale merged commit 738cdd3 into opensearch-project:main Sep 2, 2024
32 checks passed
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.90%. Comparing base (b54e867) to head (840fefb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...org/opensearch/cluster/metadata/IndexMetadata.java 0.00% 0 Missing and 4 partials ⚠️
...ction/admin/indices/create/CreateIndexRequest.java 0.00% 0 Missing and 2 partials ⚠️
...rch/action/admin/indices/get/GetIndexResponse.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15572      +/-   ##
============================================
- Coverage     71.97%   71.90%   -0.07%     
+ Complexity    63823    63802      -21     
============================================
  Files          5250     5250              
  Lines        297861   298153     +292     
  Branches      43039    43076      +37     
============================================
+ Hits         214374   214382       +8     
- Misses        65962    66212     +250     
- Partials      17525    17559      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants