Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Simplify diff calculation for remote routing table #15582

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7247266 from #15100.

Simplify diff calculation logic for remote routing table

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Co-authored-by: Shailendra Singh <singhlhs@amazon.com>
(cherry picked from commit 7247266)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for 51e135c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 2, 2024

✅ Gradle check result for 51e135c: SUCCESS

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 79.82456% with 23 lines in your changes missing coverage. Please review.

Project coverage is 71.78%. Comparing base (8a9c167) to head (51e135c).
Report is 6 commits behind head on 2.x.

Files with missing lines Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 60.60% 6 Missing and 7 partials ⚠️
...earch/gateway/remote/ClusterStateDiffManifest.java 86.95% 1 Missing and 2 partials ⚠️
...h/cluster/routing/RoutingTableIncrementalDiff.java 94.11% 2 Missing ⚠️
...ay/remote/model/RemoteClusterMetadataManifest.java 33.33% 1 Missing and 1 partial ⚠️
...a/org/opensearch/cluster/routing/RoutingTable.java 50.00% 1 Missing ⚠️
...search/gateway/remote/ClusterMetadataManifest.java 90.00% 1 Missing ⚠️
...ay/remote/routingtable/RemoteRoutingTableDiff.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15582      +/-   ##
============================================
+ Coverage     71.64%   71.78%   +0.14%     
- Complexity    63909    64005      +96     
============================================
  Files          5240     5239       -1     
  Lines        299047   299043       -4     
  Branches      43535    43543       +8     
============================================
+ Hits         214244   214671     +427     
+ Misses        66881    66409     -472     
- Partials      17922    17963      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bukhtawar Bukhtawar merged commit 50f411e into 2.x Sep 3, 2024
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant