Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Star Tree] Interfaces Fixes for Star Tree Search #15603

Merged

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Sep 3, 2024

Description

This change allows the search flows to access StarTreeMetadata so that they can make a decision to cache the query or not based on segment max doc and number of star tree documents.

It also removes the assertion when the child node is not found so that we can gracefully handle the scenarios where we dimension value does not exist in the children.

Related Issues

Resolves #15604

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 6c075c1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sarthakaggarwal97 sarthakaggarwal97 added skip-changelog and removed enhancement Enhancement or improvement to existing feature or request Search:Aggregations labels Sep 3, 2024
@sarthakaggarwal97 sarthakaggarwal97 changed the title [Star Tree] Interfaces Improvements for Star Tree Search [Star Tree] Interfaces Fixes for Star Tree Search Sep 3, 2024
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search:Aggregations labels Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 4f9dea8: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 6b67535: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 3, 2024

✅ Gradle check result for bb4d53f: SUCCESS

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 08722e1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 08722e1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❕ Gradle check result for 08722e1: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod
      1 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.testResizeQueueDown

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.37%. Comparing base (70ba5a1) to head (08722e1).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...eindex/datacube/startree/index/StarTreeValues.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15603      +/-   ##
============================================
- Coverage     71.90%   71.37%   -0.54%     
+ Complexity    63869    63298     -571     
============================================
  Files          5257     5257              
  Lines        298675   298675              
  Branches      43184    43183       -1     
============================================
- Hits         214775   213178    -1597     
- Misses        66165    67864    +1699     
+ Partials      17735    17633     -102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit 12f6493 into opensearch-project:main Sep 3, 2024
33 of 35 checks passed
@sarthakaggarwal97 sarthakaggarwal97 added the backport 2.x Backport to 2.x branch label Sep 3, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 12f6493)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Sep 3, 2024
(cherry picked from commit 12f6493)

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Search:Aggregations skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Interface Fixes for Star Tree Search
4 participants