-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RW Separation] Add polling segment replication for search replicas #15627
Conversation
server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
❕ Gradle check result for aef15f9: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
This PR introduces polling for search replicas at the existing refresh interval. If any index has a search replica will trigger segrep on an interval. Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15627-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 375c0bf1c9ac9ff7226d447bcd1dddfcedd856fc
# Push it to GitHub
git push --set-upstream origin backport/backport-15627-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15627-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 375c0bf1c9ac9ff7226d447bcd1dddfcedd856fc
# Push it to GitHub
git push --set-upstream origin backport/backport-15627-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17 Then, create a pull request where the |
…pensearch-project#15627) (cherry picked from commit 375c0bf)
…pensearch-project#15627) (cherry picked from commit 375c0bf) Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
…pensearch-project#15627) (cherry picked from commit 375c0bf) Signed-off-by: Marc Handalian <marc.handalian@gmail.com> (cherry picked from commit d3b3a93)
…pensearch-project#15627) (cherry picked from commit 375c0bf) Signed-off-by: Marc Handalian <marc.handalian@gmail.com> (cherry picked from commit d3b3a93) Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
…earch replicas (#15627) (#15718) * [RW Separation] Add polling segment replication for search replicas (#15627) (cherry picked from commit 375c0bf) Signed-off-by: Marc Handalian <marc.handalian@gmail.com> (cherry picked from commit d3b3a93) Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * fix compilation from extra ctors on 2.x line Signed-off-by: Marc Handalian <marc.handalian@gmail.com> --------- Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Description
Add segment replication polling for search replicas. This PR introduces segrep polling for search replicas at the existing refresh interval. If the feature flag is enabled an async task from IndexService will trigger replication.
Related Issues
Related #4577
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.