Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] ClusterManagerTaskThrottler Improvements #15647

Merged

Conversation

sumitasr
Copy link
Member

@sumitasr sumitasr commented Sep 4, 2024

2.x backport of #15508

* [ClusterManagerTaskThrottler Improvements] : Add shallow check in ClusterManagerTaskThrottler to fail fast before computeIfPresent to avoid lock when queue is full

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
(cherry picked from commit 17b5f98)
@sumitasr sumitasr marked this pull request as ready for review September 4, 2024 07:25
@sumitasr sumitasr changed the title Backport/backport 15508 to 2.x [Backport 2.x] ClusterManagerTaskThrottler Improvements Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❕ Gradle check result for 9517328: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for d101718: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sumitasr sumitasr force-pushed the backport/backport-15508-to-2.x branch from 2db05c8 to 5504f32 Compare September 6, 2024 07:16
@sumitasr
Copy link
Member Author

sumitasr commented Sep 6, 2024

2.x cut off was done and this is already merged to 2.17 now. Removed entry from CHANGELOG.md

…8-to-2.x

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
@sumitasr sumitasr force-pushed the backport/backport-15508-to-2.x branch from c3929d5 to a0ecb30 Compare September 6, 2024 07:22
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for 2db05c8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for c3929d5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for 5504f32: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for a0ecb30: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for a0ecb30: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sumitasr
Copy link
Member Author

sumitasr commented Sep 6, 2024

❌ Gradle check result for a0ecb30: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.snapshots.DeleteSnapshotITV2.testRemoteStoreCleanupForDeletedIndexForSnapshotV2

Flaky #15692

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for a0ecb30: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 9, 2024

✅ Gradle check result for 01ebc58: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants