[Backport 2.17] ClusterManagerTaskThrottler Improvements (#15508) #15671
Conversation
* [ClusterManagerTaskThrottler Improvements] : Add shallow check in ClusterManagerTaskThrottler to fail fast before computeIfPresent to avoid lock when queue is full Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
sumitasr
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 2514950: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
|
❌ Gradle check result for 27fabde: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
1 similar comment
|
❌ Gradle check result for 27fabde: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
|
❌ Gradle check result for 9e194fc: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
|
❌ Gradle check result for 3894564: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
5 similar comments
|
❌ Gradle check result for 3894564: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 3894564: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 3894564: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 3894564: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 3894564: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: shwetathareja <shwetathareja@live.com>
|
❌ Gradle check result for 2ba1bac: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks |
Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.17 #15671 +/- ##
============================================
- Coverage 71.77% 71.73% -0.05%
+ Complexity 64298 64290 -8
============================================
Files 5251 5251
Lines 300482 300490 +8
Branches 43724 43723 -1
============================================
- Hits 215672 215554 -118
- Misses 66760 66976 +216
+ Partials 18050 17960 -90 ☔ View full report in Codecov by Sentry. |
2.17 Backport to #15508