New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integ Test for RemotePublication can be disabled by rolling restart of masters #15677

Merged

shwetathareja merged 4 commits into opensearch-project:main from shiv0408:publish-disable-it

Sep 5, 2024

Member

shiv0408 commented Sep 4, 2024 •

edited

Loading

Description

Integ Test for RemotePublication can be disabled by rolling restart of masters

To Disable the Remote Publication, disable the remote publication flag on the nodes and do a rolling restart of the master nodes.

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

shiv0408 requested review from anasalkouz, andrross, ashking94, Bukhtawar, CEHENKLE, dblock, dbwiddis, gbbafna, jainankitk, kotwanikunal, linuxpi, mch2, msfroh, nknize, owaiskazi19, reta, Rishikesh1159, sachinpkale, saratvemulapalli, shwetathareja, sohami and VachaShah as code owners

September 4, 2024 12:30

Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 9ffab92: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

shiv0408 added the skip-changelog label

Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 9ffab92: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?


          Integ Test for RemotePublication can be disabled by rolling restart o…

e39e17a

…f masters

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

shiv0408 force-pushed the publish-disable-it branch from 9ffab92 to e39e17a Compare

September 4, 2024 16:19

Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for e39e17a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for e39e17a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Member Author

shiv0408 commented Sep 4, 2024 •

edited

Loading

❌ Gradle check result for e39e17a: FAILURE

https://build.ci.opensearch.org/job/gradle-check/46871/testReport/junit/org.opensearch.snapshots/DeleteSnapshotITV2/testRemoteStoreCleanupForDeletedIndexForSnapshotV2/ - #15692


          Merge branch 'main' into publish-disable-it

6320bc0

shwetathareja added backport 2.x backport 2.17 labels

Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for c5920cf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?


          Merge branch 'main' into publish-disable-it

fad6eaf

shiv0408 added the v2.17.0 label

Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for fad6eaf: SUCCESS

codecov bot commented Sep 5, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.84%. Comparing base (729e40d) to head (fad6eaf).
Report is 12 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15677      +/-   ##
============================================
- Coverage     71.95%   71.84%   -0.12%     
+ Complexity    64192    64147      -45     
============================================
  Files          5270     5271       +1     
  Lines        300052   300166     +114     
  Branches      43368    43380      +12     
============================================
- Hits         215917   215647     -270     
- Misses        66442    66822     +380     
- Partials      17693    17697       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shwetathareja approved these changes

View reviewed changes

shwetathareja merged commit 2eb148c into opensearch-project:main

38 checks passed

shwetathareja removed backport 2.17 v2.17.0 labels

opensearch-trigger-bot bot pushed a commit that referenced this pull request


          Integ Test for RemotePublication can be disabled by rolling restart o…

cf0486a

…f masters (#15677)

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit 2eb148c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

opensearch-trigger-bot bot mentioned this pull request

[Backport 2.x] Integ Test for RemotePublication can be disabled by rolling restart of masters #15753

Closed

opensearch-trigger-bot bot pushed a commit that referenced this pull request


          Integ Test for RemotePublication can be disabled by rolling restart o…

0b1399c

…f masters (#15677)

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit 2eb148c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

opensearch-trigger-bot bot mentioned this pull request

[Backport 2.17] Integ Test for RemotePublication can be disabled by rolling restart of masters #15754

Closed

shiv0408 deleted the publish-disable-it branch

September 5, 2024 18:13

shiv0408 mentioned this pull request

Revert "Integ Test for RemotePublication can be disabled by rolling restart of masters" #15766

Closed

This was referenced Sep 6, 2024

[AUTOCUT] Gradle Check Flaky Test Report for DedicatedClusterSnapshotRestoreIT #15806

Open

[AUTOCUT] Gradle Check Flaky Test Report for DeleteSnapshotITV2 #15808

Open

[AUTOCUT] Gradle Check Flaky Test Report for PluginInfoIT #15814

Open

akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request


          Integ Test for RemotePublication can be disabled by rolling restart o…

7806b9f

…f masters (opensearch-project#15677)

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

This was referenced Sep 11, 2024

[AUTOCUT] Gradle Check Flaky Test Report for MixedClusterClientYamlTestSuiteIT #14294

Open

[AUTOCUT] Gradle Check Flaky Test Report for MinimumClusterManagerNodesIT #14289

Open

[AUTOCUT] Gradle Check Flaky Test Report for RemoteStoreStatsIT #14310

Open

[AUTOCUT] Gradle Check Flaky Test Report for RecoveryFromGatewayIT #14304

Open

prudhvigodithi mentioned this pull request

[AUTOCUT] Gradle Check Flaky Test Report for MixedClusterClientYamlTestSuiteIT prudhvigodithi/opensearch-build#82

Open

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request


          Integ Test for RemotePublication can be disabled by rolling restart o…

5650f16

…f masters (opensearch-project#15677)

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request


          Integ Test for RemotePublication can be disabled by rolling restart o…

64ee69e

…f masters (opensearch-project#15677)

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request


          Integ Test for RemotePublication can be disabled by rolling restart o…

02f4859

…f masters (opensearch-project#15677)

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shwetathareja shwetathareja approved these changes

anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

andrross Awaiting requested review from andrross andrross is a code owner

ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

dblock Awaiting requested review from dblock dblock is a code owner

dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

mch2 Awaiting requested review from mch2 mch2 is a code owner

msfroh Awaiting requested review from msfroh msfroh is a code owner

nknize Awaiting requested review from nknize nknize is a code owner

owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

reta Awaiting requested review from reta reta is a code owner

Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

sohami Awaiting requested review from sohami sohami is a code owner

VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Labels

backport 2.x skip-changelog