Remove awaits fix for ApproximatePointRangeQuery tests #15727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
bug
harshavamsi
added
backport 2.x
github-actions
bot
added
bug
harshavamsi
changed the title
|
❌ Gradle check result for d6e8ff3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for d6e8ff3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b846d4e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15727 +/- ##
============================================
- Coverage 71.95% 71.94% -0.02%
+ Complexity 64192 64191 -1
============================================
Files 5270 5271 +1
Lines 300052 300166 +114
Branches 43368 43380 +12
============================================
+ Hits 215917 215967 +50
- Misses 66442 66468 +26
- Partials 17693 17731 +38 ☔ View full report in Codecov by Sentry. |
jainankitk
reviewed
Sep 5, 2024
server/src/test/java/org/opensearch/search/approximate/ApproximatePointRangeQueryTests.java
Show resolved
Hide resolved
harshavamsi
changed the title
msfroh
approved these changes
Sep 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> (cherry picked from commit 7cb2bd0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jainankitk
pushed a commit
that referenced
this pull request
Sep 9, 2024
…hortCircuitAscSort by enforcing sorting behavior after collecting docIDs (#15727) (#15871) (cherry picked from commit 7cb2bd0) Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
This was referenced Sep 11, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove awaits fix for flaky tests that have been fixed in #15590
Related Issues
Resolves #15600
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.