Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Restore snapshot changes for shallow snapshot V2 (#15462) #15738

Merged

Conversation

sachinpkale
Copy link
Member

Backport 7a9cb35 from #15462

Conflicts in: IndexShard and StoreRecovery classes.

Version is changed in RecoverySource and RestoreSnapshotRequest from CURRENT to 2.17.0

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 56a5dbe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❕ Gradle check result for befd1fa: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 31.14754% with 126 lines in your changes missing coverage. Please review.

Project coverage is 71.71%. Comparing base (75fb5bc) to head (68f2190).
Report is 7 commits behind head on 2.17.

Files with missing lines Patch % Lines
...java/org/opensearch/index/shard/StoreRecovery.java 0.00% 61 Missing ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java 26.47% 20 Missing and 5 partials ⚠️
...ch/repositories/blobstore/BlobStoreRepository.java 22.22% 11 Missing and 3 partials ⚠️
...org/opensearch/cluster/routing/RecoverySource.java 52.38% 6 Missing and 4 partials ⚠️
...ster/snapshots/restore/RestoreSnapshotRequest.java 33.33% 3 Missing and 5 partials ⚠️
...rg/opensearch/index/translog/RemoteFsTranslog.java 25.00% 1 Missing and 2 partials ⚠️
.../org/opensearch/index/translog/TranslogConfig.java 50.00% 2 Missing ⚠️
...search/snapshots/InternalSnapshotsInfoService.java 84.61% 1 Missing and 1 partial ⚠️
...n/java/org/opensearch/repositories/Repository.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.17   #15738      +/-   ##
============================================
+ Coverage     71.66%   71.71%   +0.04%     
- Complexity    64317    64420     +103     
============================================
  Files          5262     5263       +1     
  Lines        301148   301332     +184     
  Branches      43841    43877      +36     
============================================
+ Hits         215829   216105     +276     
+ Misses        67259    67143     -116     
- Partials      18060    18084      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
@sachinpkale sachinpkale force-pushed the backport-15462-to-2.17 branch from befd1fa to 68f2190 Compare September 5, 2024 15:41
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 68f2190: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 68f2190: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 68f2190: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants